From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoHr2-0004yH-La for qemu-devel@nongnu.org; Mon, 19 Oct 2015 17:20:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoHqx-0002Sq-OK for qemu-devel@nongnu.org; Mon, 19 Oct 2015 17:20:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoHqx-0002Sk-Jm for qemu-devel@nongnu.org; Mon, 19 Oct 2015 17:20:23 -0400 Date: Tue, 20 Oct 2015 00:20:18 +0300 From: "Michael S. Tsirkin" Message-ID: <20151020001940-mutt-send-email-mst@redhat.com> References: <1444535584-18220-1-git-send-email-guangrong.xiao@linux.intel.com> <1444535584-18220-23-git-send-email-guangrong.xiao@linux.intel.com> <20151019095612-mutt-send-email-mst@redhat.com> <20151019111836.2e830737@igors-macbook-pro.local> <20151019132401-mutt-send-email-mst@redhat.com> <56252E44.9050901@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56252E44.9050901@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH v3 22/32] nvdimm: init the address region used by NVDIMM ACPI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, Igor Mammedov , dan.j.williams@intel.com, rth@twiddle.net On Tue, Oct 20, 2015 at 01:54:12AM +0800, Xiao Guangrong wrote: > > > On 10/19/2015 06:25 PM, Michael S. Tsirkin wrote: > >On Mon, Oct 19, 2015 at 11:18:36AM +0200, Igor Mammedov wrote: > >>On Mon, 19 Oct 2015 09:56:12 +0300 > >>"Michael S. Tsirkin" wrote: > >> > >>>On Sun, Oct 11, 2015 at 11:52:54AM +0800, Xiao Guangrong wrote: > >>[...] > >>>>diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h > >>>>index f6bd2c4..aa95961 100644 > >>>>--- a/include/hw/mem/nvdimm.h > >>>>+++ b/include/hw/mem/nvdimm.h > >>>>@@ -15,6 +15,10 @@ > >>>> > >>>> #include "hw/mem/dimm.h" > >>>> > >>>>+/* Memory region 0xFF00000 ~ 0xFFF00000 is reserved for NVDIMM > >>>>ACPI. */ +#define NVDIMM_ACPI_MEM_BASE 0xFF000000ULL > >>Michael, > >> > >>If it's ok to map control RAM region directly from QEMU at arbitrary > >>location > > > >It's a fair question. Where is it reserved? In which spec? > > > > The region 0xFF00000 ~ 0xFFF00000 is just reserved for vDSM implementation, > it is not required by spec. See Igor's comment then. You can't just steal it like that. -- MST