[Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling

[Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling

[Pavel Fedin]

 Hello! Is there any progress on this?
 6/7 significantly improves startup performance, i'd like to have it accepted.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia


> -----Original Message-----
> From: qemu-devel-bounces+p.fedin=samsung.com@nongnu.org [mailto:qemu-devel-
> bounces+p.fedin=samsung.com@nongnu.org] On Behalf Of Pavel Fedin
> Sent: Wednesday, October 14, 2015 9:58 AM
> To: 'Daniel P. Berrange'; qemu-devel@nongnu.org
> Cc: 'Paolo Bonzini'; 'Markus Armbruster'; 'Andreas Färber'
> Subject: Re: [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling
> 
>  Hello!
> 
> > This series introduces a concept of object property iterators
> > to QOM so callers are insulated from the specific data structures
> > used for storing properties against objects/classes. It then
> > converts Object to use a GHashTable for storing properties.
> > Finally it introduces ObjectClass properties.
> 
>  Tested-by: Pavel Fedin <p.fedin@samsung.com>
> 
> > Probably the only controversial thing is the item Pavel points
> > out about object_child_foreach iterators now being forbidden
> > from modifying the object composition tree.
> 
>  As i already wrote, current code does not modify the tree. If necessary, it is possible to
> work around (e. g. make a decision about modification, stop iteration, then do the
> modification). I think this would pop up anyway if we change list to anything else. IMHO it's
> better just to acknowledge that we should not modify our tree inside iterator.
> 
> Kind regards,
> Pavel Fedin
> Expert Engineer
> Samsung Electronics Research center Russia
> 

Re: [Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling

[Paolo Bonzini]

On 20/10/2015 13:38, Pavel Fedin wrote:
>  Hello! Is there any progress on this?
>  6/7 significantly improves startup performance, i'd like to have it accepted.

Me too. :)

I am waiting for Andreas, since he's the maintainer for QOM.

Paolo

> 
>> -----Original Message-----
>> From: qemu-devel-bounces+p.fedin=samsung.com@nongnu.org [mailto:qemu-devel-
>> bounces+p.fedin=samsung.com@nongnu.org] On Behalf Of Pavel Fedin
>> Sent: Wednesday, October 14, 2015 9:58 AM
>> To: 'Daniel P. Berrange'; qemu-devel@nongnu.org
>> Cc: 'Paolo Bonzini'; 'Markus Armbruster'; 'Andreas Färber'
>> Subject: Re: [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling
>>
>>  Hello!
>>
>>> This series introduces a concept of object property iterators
>>> to QOM so callers are insulated from the specific data structures
>>> used for storing properties against objects/classes. It then
>>> converts Object to use a GHashTable for storing properties.
>>> Finally it introduces ObjectClass properties.
>>
>>  Tested-by: Pavel Fedin <p.fedin@samsung.com>
>>
>>> Probably the only controversial thing is the item Pavel points
>>> out about object_child_foreach iterators now being forbidden
>>> from modifying the object composition tree.
>>
>>  As i already wrote, current code does not modify the tree. If necessary, it is possible to
>> work around (e. g. make a decision about modification, stop iteration, then do the
>> modification). I think this would pop up anyway if we change list to anything else. IMHO it's
>> better just to acknowledge that we should not modify our tree inside iterator.
>>
>> Kind regards,
>> Pavel Fedin
>> Expert Engineer
>> Samsung Electronics Research center Russia
>>
> 
> 

Re: [Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling

[Daniel P. Berrange]

On Tue, Oct 20, 2015 at 02:15:53PM +0200, Paolo Bonzini wrote:
> 
> 
> On 20/10/2015 13:38, Pavel Fedin wrote:
> >  Hello! Is there any progress on this?
> >  6/7 significantly improves startup performance, i'd like to have it accepted.
> 
> Me too. :)
> 
> I am waiting for Andreas, since he's the maintainer for QOM.

Andreas had asked me to rebase the new patches against the old v2
of the class-props patch, since he already had that in his local
tree.  I'll try to get a rebased series posted today / tomorrow.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

Re: [Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling

[Andreas Färber]

Am 20.10.2015 um 14:15 schrieb Paolo Bonzini:
> On 20/10/2015 13:38, Pavel Fedin wrote:
>>  Hello! Is there any progress on this?
>>  6/7 significantly improves startup performance, i'd like to have it accepted.
> 
> Me too. :)
> 
> I am waiting for Andreas, since he's the maintainer for QOM.

Pavel, adding a Tested-by does not automagically make the patch accepted.

Two problems apart from time: 1) Discussions about iterator design, 2)
lack of test cases, and that applies to iterator-less v2, too. Circles
back to me (or someone) looking into qom-proplist test.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling

[Daniel P. Berrange]

On Tue, Oct 20, 2015 at 02:38:43PM +0200, Andreas Färber wrote:
> Am 20.10.2015 um 14:15 schrieb Paolo Bonzini:
> > On 20/10/2015 13:38, Pavel Fedin wrote:
> >>  Hello! Is there any progress on this?
> >>  6/7 significantly improves startup performance, i'd like to have it accepted.
> > 
> > Me too. :)
> > 
> > I am waiting for Andreas, since he's the maintainer for QOM.
> 
> Pavel, adding a Tested-by does not automagically make the patch accepted.
> 
> Two problems apart from time: 1) Discussions about iterator design, 2)
> lack of test cases, and that applies to iterator-less v2, too. Circles
> back to me (or someone) looking into qom-proplist test.

FYI in the v4 posting, I added to the check-qom-proplist.c test case
to cover the new iterator APIs. I further added to it in the later
patches to cover the iteration of properties against classes. The v4
also has the alternative iterator design that Markus / Paolo preferred,
that avoids use of callback functions.

I can further test cases to do more coverage of object proprty handling
wrt to classes, if you want me to.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

Re: [Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling

[Andreas Färber]

Am 20.10.2015 um 14:54 schrieb Daniel P. Berrange:
> On Tue, Oct 20, 2015 at 02:38:43PM +0200, Andreas Färber wrote:
>> Two problems apart from time: 1) Discussions about iterator design, 2)
>> lack of test cases, and that applies to iterator-less v2, too. Circles
>> back to me (or someone) looking into qom-proplist test.
> 
> FYI in the v4 posting, I added to the check-qom-proplist.c test case
> to cover the new iterator APIs. I further added to it in the later
> patches to cover the iteration of properties against classes. The v4
> also has the alternative iterator design that Markus / Paolo preferred,
> that avoids use of callback functions.
> 
> I can further test cases to do more coverage of object proprty handling
> wrt to classes, if you want me to.

No, if that is sorted out now, I'll drop v2 and need to review v4.

Cheers,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)