qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Pavel Fedin <p.fedin@samsung.com>,
	qemu-devel@nongnu.org, 'Markus Armbruster' <armbru@redhat.com>
Subject: Re: [Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling
Date: Tue, 20 Oct 2015 13:54:34 +0100	[thread overview]
Message-ID: <20151020125434.GI14616@redhat.com> (raw)
In-Reply-To: <562635D3.9010501@suse.de>

On Tue, Oct 20, 2015 at 02:38:43PM +0200, Andreas Färber wrote:
> Am 20.10.2015 um 14:15 schrieb Paolo Bonzini:
> > On 20/10/2015 13:38, Pavel Fedin wrote:
> >>  Hello! Is there any progress on this?
> >>  6/7 significantly improves startup performance, i'd like to have it accepted.
> > 
> > Me too. :)
> > 
> > I am waiting for Andreas, since he's the maintainer for QOM.
> 
> Pavel, adding a Tested-by does not automagically make the patch accepted.
> 
> Two problems apart from time: 1) Discussions about iterator design, 2)
> lack of test cases, and that applies to iterator-less v2, too. Circles
> back to me (or someone) looking into qom-proplist test.

FYI in the v4 posting, I added to the check-qom-proplist.c test case
to cover the new iterator APIs. I further added to it in the later
patches to cover the iteration of properties against classes. The v4
also has the alternative iterator design that Markus / Paolo preferred,
that avoids use of callback functions.

I can further test cases to do more coverage of object proprty handling
wrt to classes, if you want me to.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

  reply	other threads:[~2015-10-20 12:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 11:38 [Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object property handling Pavel Fedin
2015-10-20 12:15 ` Paolo Bonzini
2015-10-20 12:25   ` Daniel P. Berrange
2015-10-20 12:38   ` Andreas Färber
2015-10-20 12:54     ` Daniel P. Berrange [this message]
2015-10-20 13:17       ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151020125434.GI14616@redhat.com \
    --to=berrange@redhat.com \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=p.fedin@samsung.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).