From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44526)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZoWR9-0000nf-1e
	for qemu-devel@nongnu.org; Tue, 20 Oct 2015 08:54:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZoWR5-0007DI-A4
	for qemu-devel@nongnu.org; Tue, 20 Oct 2015 08:54:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57940)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZoWR4-0007DE-O4
	for qemu-devel@nongnu.org; Tue, 20 Oct 2015 08:54:38 -0400
Date: Tue, 20 Oct 2015 13:54:34 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20151020125434.GI14616@redhat.com>
References: <025701d10b2b$d833d5b0$889b8110$@samsung.com>
	<56263079.6070306@redhat.com> <562635D3.9010501@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <562635D3.9010501@suse.de>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] PING: [PATCH v4 0/7] qom: more efficient object
 property handling
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Pavel Fedin <p.fedin@samsung.com>, qemu-devel@nongnu.org, 'Markus Armbruster' <armbru@redhat.com>

On Tue, Oct 20, 2015 at 02:38:43PM +0200, Andreas F=C3=A4rber wrote:
> Am 20.10.2015 um 14:15 schrieb Paolo Bonzini:
> > On 20/10/2015 13:38, Pavel Fedin wrote:
> >>  Hello! Is there any progress on this?
> >>  6/7 significantly improves startup performance, i'd like to have it=
 accepted.
> >=20
> > Me too. :)
> >=20
> > I am waiting for Andreas, since he's the maintainer for QOM.
>=20
> Pavel, adding a Tested-by does not automagically make the patch accepte=
d.
>=20
> Two problems apart from time: 1) Discussions about iterator design, 2)
> lack of test cases, and that applies to iterator-less v2, too. Circles
> back to me (or someone) looking into qom-proplist test.

FYI in the v4 posting, I added to the check-qom-proplist.c test case
to cover the new iterator APIs. I further added to it in the later
patches to cover the iteration of properties against classes. The v4
also has the alternative iterator design that Markus / Paolo preferred,
that avoids use of callback functions.

I can further test cases to do more coverage of object proprty handling
wrt to classes, if you want me to.

Regards,
Daniel
--=20
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange=
/ :|
|: http://libvirt.org              -o-             http://virt-manager.or=
g :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr=
/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vn=
c :|