qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: "Cornelia Huck" <cornelia.huck@de.ibm.com>,
	aneesh.kumar@linux.vnet.ibm.com, qemu-devel@nongnu.org,
	"Andreas Färber" <afaerber@suse.de>,
	"Alexander Graf" <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v3 0/5] virtio-9p: hotplug and migration support
Date: Tue, 20 Oct 2015 15:53:08 +0300	[thread overview]
Message-ID: <20151020155225-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20151020091640.25419.99985.stgit@bahia.huguette.org>

On Tue, Oct 20, 2015 at 11:16:40AM +0200, Greg Kurz wrote:
> We already have a blocker to prevent migration of an active virtio-9p device.
> But in fact, there is no migration support at all for 9p, even if the device
> is considered to be quiescent (when the VirtFS share is not mounted): migration
> succeeds but the device is lost in the restarted guest.
> Hotunplug of a virtio-9p device is not supported either (no unrealize handler)
> and leads to a QEMU crash on the source node, if one unplugs and migrates.
> 
> This series tries to fix that and brings hotplug and migration support of
> *quiescent* virtio-9p devices.
> 
> v2->v3:
>  - renamed QDEV handler @unpluggable to @unplug_is_blocked (patches 2/5
>    and 3/5)
> 
> v1->v2:
>  - introduced unplug blocker (patches 2/5 and 3/5)
>  - moved fixes to separate patches (see individual changelogs)

I have some doubts about how hotunplug is handled, but migration
looks ok.
Is there a dependency, or can I just pick savevm things meanwhile?

> ---
> 
> Greg Kurz (5):
>       virtio-9p-coth: fix init function
>       qdev: add the @unplug_is_blocked handler
>       virtio-9p: block hot-unplug when device is active
>       virtio-9p: add unrealize handler
>       virtio-9p: add savem handlers
> 
> 
>  hw/9pfs/virtio-9p-coth.c   |   22 ++++++++++++++++++----
>  hw/9pfs/virtio-9p-coth.h   |    2 ++
>  hw/9pfs/virtio-9p-device.c |   24 ++++++++++++++++++++++++
>  hw/9pfs/virtio-9p.c        |   14 ++++++++++++++
>  hw/9pfs/virtio-9p.h        |    2 ++
>  hw/core/qdev.c             |    4 ++++
>  hw/s390x/virtio-ccw.c      |    8 ++++++++
>  hw/virtio/virtio-pci.c     |    8 ++++++++
>  include/hw/qdev-core.h     |    4 ++++
>  9 files changed, 84 insertions(+), 4 deletions(-)

  parent reply	other threads:[~2015-10-20 12:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20  9:16 [Qemu-devel] [PATCH v3 0/5] virtio-9p: hotplug and migration support Greg Kurz
2015-10-20  9:16 ` [Qemu-devel] [PATCH v3 1/5] virtio-9p-coth: fix init function Greg Kurz
2015-10-20  9:16 ` [Qemu-devel] [PATCH v3 2/5] qdev: add the @unplug_is_blocked handler Greg Kurz
2015-10-20  9:17 ` [Qemu-devel] [PATCH v3 3/5] virtio-9p: block hot-unplug when device is active Greg Kurz
2015-10-20 12:42   ` Michael S. Tsirkin
2015-10-20 17:08     ` Greg Kurz
2015-10-20  9:17 ` [Qemu-devel] [PATCH v3 4/5] virtio-9p: add unrealize handler Greg Kurz
2015-10-20  9:17 ` [Qemu-devel] [PATCH v3 5/5] virtio-9p: add savem handlers Greg Kurz
2015-10-20 12:53 ` Michael S. Tsirkin [this message]
2015-10-20 18:00   ` [Qemu-devel] [PATCH v3 0/5] virtio-9p: hotplug and migration support Greg Kurz
2015-10-20 19:39     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151020155225-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=gkurz@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).