From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoZQM-0001D4-DI for qemu-devel@nongnu.org; Tue, 20 Oct 2015 12:06:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoZQH-0004Na-Mi for qemu-devel@nongnu.org; Tue, 20 Oct 2015 12:06:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoZQH-0004NT-Ga for qemu-devel@nongnu.org; Tue, 20 Oct 2015 12:06:01 -0400 Date: Tue, 20 Oct 2015 19:05:56 +0300 From: "Michael S. Tsirkin" Message-ID: <20151020190501-mutt-send-email-mst@redhat.com> References: <1445216059-88521-1-git-send-email-guangrong.xiao@linux.intel.com> <1445216059-88521-29-git-send-email-guangrong.xiao@linux.intel.com> <20151020155149.GB2772@stefanha-thinkpad.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151020155149.GB2772@stefanha-thinkpad.home> Subject: Re: [Qemu-devel] [PATCH v4 28/33] nvdimm acpi: support DSM_FUN_IMPLEMENTED function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Xiao Guangrong , ehabkost@redhat.com, kvm@vger.kernel.org, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan.j.williams@intel.com, rth@twiddle.net On Tue, Oct 20, 2015 at 04:51:49PM +0100, Stefan Hajnoczi wrote: > On Mon, Oct 19, 2015 at 08:54:14AM +0800, Xiao Guangrong wrote: > > +exit: > > + /* Write our output result to dsm memory. */ > > + ((dsm_out *)dsm_ram_addr)->len = out->len; > > Missing byteswap? That's why I'd prefer no structures, using build_append_int_noprefix, unless the structure is used outside ACPI as well. > I thought you were going to remove this field because it wasn't needed > by the guest.