From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40204)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZoqqV-0001X3-CA
	for qemu-devel@nongnu.org; Wed, 21 Oct 2015 06:42:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZoqqS-00032l-3Z
	for qemu-devel@nongnu.org; Wed, 21 Oct 2015 06:42:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43017)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZoqqR-00032b-UE
	for qemu-devel@nongnu.org; Wed, 21 Oct 2015 06:42:12 -0400
Date: Wed, 21 Oct 2015 13:42:09 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151021134130-mutt-send-email-mst@redhat.com>
References: <1444979941-8486-1-git-send-email-yuanhan.liu@linux.intel.com>
	<20151016102015-mutt-send-email-mst@redhat.com>
	<20151016073256.GA12777@yliu-dev.sh.intel.com>
	<20151016103429-mutt-send-email-mst@redhat.com>
	<20151021085516.GE3115@yliu-dev.sh.intel.com>
	<20151021121142-mutt-send-email-mst@redhat.com>
	<20151021092140.GF3115@yliu-dev.sh.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151021092140.GF3115@yliu-dev.sh.intel.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] Revert "vhost: rename
 VHOST_RESET_OWNER to VHOST_RESET_DEVICE"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: qemu-devel@nongnu.org

On Wed, Oct 21, 2015 at 05:21:40PM +0800, Yuanhan Liu wrote:
> On Wed, Oct 21, 2015 at 12:15:52PM +0300, Michael S. Tsirkin wrote:
> > On Wed, Oct 21, 2015 at 04:55:16PM +0800, Yuanhan Liu wrote:
> > > On Fri, Oct 16, 2015 at 10:47:49AM +0300, Michael S. Tsirkin wrote:
> > > > On Fri, Oct 16, 2015 at 03:32:56PM +0800, Yuanhan Liu wrote:
> > > > > On Fri, Oct 16, 2015 at 10:21:40AM +0300, Michael S. Tsirkin wrote:
> > > > > > On Fri, Oct 16, 2015 at 03:18:59PM +0800, Yuanhan Liu wrote:
> > > > > > > This reverts commit d1f8b30ec8dde0318fd1b98d24a64926feae9625.
> > > > > > > 
> > > > > > > It turned out that it breaks stuff, so revert it:
> > > > > > > 
> > > > > > >     http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg00949.html
> > > > > > > 
> > > > > > > CC: "Michael S. Tsirkin" <mst@redhat.com>
> > > > > > > Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> > > > > > > Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > > > > > 
> > > > > > OK but that's not enough. We need to also
> > > > > > - drop patch sending this on stop
> > > > > 
> > > > > I could do that. But may I know why we have to drop it on stop?
> > > > 
> > > > Because we need to get the state from remote after stop.
> > > > RESET_OWNER discards that, so we can't resume the VM.
> > > > 
> > > > > If we don't send it on stop, when will we send it? The termination
> > > > > of QEMU?
> > > > 
> > > > If mq is negotiated, we don't need it.  If mq isn't negotiated, maybe we
> > > > should send it on reset/driver unload.
> > > 
> > > Sorry, what place do you mean exactly?
> > 
> > There's no such code - you'll have to add
> > a callback into vhost from virtio.
> 
> Say, at virtio_net_reset()?
> 
> 	--yliu

Sounds good.

> > > 
> > > > It might be better than
> > > > corrupting guest memory. And if we do, maybe we should keep
> > > > the RESET_DEVICE name.