* Re: [Qemu-devel] [Qemu-stable] [PATCH] util/qemu-config: fix missing machine command line options
[not found] <1444664040-27572-1-git-send-email-akrowiak@linux.vnet.ibm.com>
@ 2015-10-21 16:12 ` Michael Roth
2015-10-21 16:21 ` Michael Roth
1 sibling, 0 replies; 2+ messages in thread
From: Michael Roth @ 2015-10-21 16:12 UTC (permalink / raw)
To: Tony Krowiak, qemu-devel; +Cc: Marcel Apfelbaum, qemu-stable
Quoting Tony Krowiak (2015-10-12 10:34:00)
> Commit 0a7cf217 ("util/qemu-config: fix regression of
> qmp_query_command_line_options") aimed to restore parsing of global
> machine options, but missed two: "aes-key-wrap" and
> "dea-key-wrap" (which were present in the initial version of that
> patch). Let's add them to the machine_opts again.
>
> Fixes: 0a7cf217
> CC: Marcel Apfelbaum <marcel@redhat.com>
> CC: qemu-stable@nongnu.org
Ping for upcoming 2.4.1 stable release
(and added qemu-devel@nongnu.org, which should be Cc'd on all patches)
> Signed-off-by: Tony Krowiak <akrowiak@linux.vnet.ibm.com>
> ---
> util/qemu-config.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/util/qemu-config.c b/util/qemu-config.c
> index 5fcfd0e..687fd34 100644
> --- a/util/qemu-config.c
> +++ b/util/qemu-config.c
> @@ -219,6 +219,14 @@ static QemuOptsList machine_opts = {
> .name = "suppress-vmdesc",
> .type = QEMU_OPT_BOOL,
> .help = "Set on to disable self-describing migration",
> + },{
> + .name = "aes-key-wrap",
> + .type = QEMU_OPT_BOOL,
> + .help = "enable/disable AES key wrapping using the CPACF wrapping key",
> + },{
> + .name = "dea-key-wrap",
> + .type = QEMU_OPT_BOOL,
> + .help = "enable/disable DEA key wrapping using the CPACF wrapping key",
> },
> { /* End of list */ }
> }
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [Qemu-stable] [PATCH] util/qemu-config: fix missing machine command line options
[not found] <1444664040-27572-1-git-send-email-akrowiak@linux.vnet.ibm.com>
2015-10-21 16:12 ` [Qemu-devel] [Qemu-stable] [PATCH] util/qemu-config: fix missing machine command line options Michael Roth
@ 2015-10-21 16:21 ` Michael Roth
1 sibling, 0 replies; 2+ messages in thread
From: Michael Roth @ 2015-10-21 16:21 UTC (permalink / raw)
To: Tony Krowiak, qemu-devel; +Cc: Marcel Apfelbaum, qemu-stable
Quoting Tony Krowiak (2015-10-12 10:34:00)
> Commit 0a7cf217 ("util/qemu-config: fix regression of
> qmp_query_command_line_options") aimed to restore parsing of global
> machine options, but missed two: "aes-key-wrap" and
> "dea-key-wrap" (which were present in the initial version of that
> patch). Let's add them to the machine_opts again.
>
> Fixes: 0a7cf217
> CC: Marcel Apfelbaum <marcel@redhat.com>
> CC: qemu-stable@nongnu.org
Nevermind the noise, just saw that this had already been resent and Cornelia
has a PULL for it already.
> Signed-off-by: Tony Krowiak <akrowiak@linux.vnet.ibm.com>
> ---
> util/qemu-config.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/util/qemu-config.c b/util/qemu-config.c
> index 5fcfd0e..687fd34 100644
> --- a/util/qemu-config.c
> +++ b/util/qemu-config.c
> @@ -219,6 +219,14 @@ static QemuOptsList machine_opts = {
> .name = "suppress-vmdesc",
> .type = QEMU_OPT_BOOL,
> .help = "Set on to disable self-describing migration",
> + },{
> + .name = "aes-key-wrap",
> + .type = QEMU_OPT_BOOL,
> + .help = "enable/disable AES key wrapping using the CPACF wrapping key",
> + },{
> + .name = "dea-key-wrap",
> + .type = QEMU_OPT_BOOL,
> + .help = "enable/disable DEA key wrapping using the CPACF wrapping key",
> },
> { /* End of list */ }
> }
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread