From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpC39-0002DL-6A for qemu-devel@nongnu.org; Thu, 22 Oct 2015 05:20:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpC35-0006Kf-UI for qemu-devel@nongnu.org; Thu, 22 Oct 2015 05:20:43 -0400 Date: Thu, 22 Oct 2015 20:20:57 +1100 From: David Gibson Message-ID: <20151022092057.GF15881@voom.fritz.box> References: <1443766573-47401-1-git-send-email-aik@ozlabs.ru> <562890EC.4080000@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qp4W5+cUSnZs0RIF" Content-Disposition: inline In-Reply-To: <562890EC.4080000@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH qemu v4] monitor/target-ppc: Define target_get_monitor_def List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Paolo Bonzini , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, peter.maydell@linaro.org --qp4W5+cUSnZs0RIF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 22, 2015 at 06:31:56PM +1100, Alexey Kardashevskiy wrote: > On 10/02/2015 04:16 PM, Alexey Kardashevskiy wrote: > >At the moment get_monitor_def() returns only registers from statically > >defined monitor_defs array. However there is a lot of BOOK3S SPRs > >which are not in the list and cannot be printed from the monitor. > > > >This adds a new target platform hook - target_get_monitor_def(). > >The hook is called if a register was not found in the static > >array returned by the target_monitor_defs() hook. > > > >The hook is only defined for POWERPC, it returns registered > >SPRs and fails on unregistered ones providing the user with information > >on what is actually supported on the running CPU. The register value is > >saved as uint64_t as it is the biggest supported register size; > >target_ulong cannot be used because of the stub - it is in a "common" > >code and cannot include "cpu.h", etc; this is also why the hook prototype > >is redefined in the stub instead of being included from some header. > > > >This replaces static descriptors for GPRs, FPRs, SRs with a helper which > >looks for a value in a corresponding array in the CPUPPCState. > >The immediate effect is that all 32 SRs can be printed now (instead of 1= 6); > >later this can be reused for VSX or TM registers. > > > >While we are here, this adds "cr" as a synonym of "ccr". > > > >Signed-off-by: Alexey Kardashevskiy > >--- > > > >Does it make sense to split it into two patches? I asked a while back if your patch or BenH's patch doing a similar thing was the one I should be looking at, and I never got a reply. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --qp4W5+cUSnZs0RIF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWKKp5AAoJEGw4ysog2bOSFYAP/A31sr00n3ZCmsQD7VD2AjQ+ 0zQYZUcJMP2Ga1t/Pf7WZEpcennc9huucU7GdLCnfjuMbvAlQN38lQQmIX/ftV8P +9hcKj9g/ewsCNGtI4p1AreNCvRge9P4lU3Pi3UqP4YYRS4IIiRFjIGz44eeBwho L7i6S97RirfTMTaVSBdj/dZFEl1IPgxvnKUHwzQel9KNIyThZ9UHwzl771f+QbM0 6PUyv0hdbEm2ApofspYC+J/u38meuioEoQ9/+P9OibJGvsDDVbr0a7UPtNoyG3p/ PxF5G7Bbu8kVrNUsDpQsvyk/gwNavexBvQ6vTcVONEbe/NZVkHR5MMC0AbyMFfr2 MJIYXoHdFHAp/1vnXteWK+xvHJFTUkcG5qRZJa3Hs8fwXn/Q0d8GBEgzF4yXO4ex 9Pd2rYlwbjoNHat4LLTsnA6ZqlZQ7y2uRCcjTS/PLK6YjzrUbM3PgvoHStSnf4KU knRk0BT67pkttY9GVytRBi0vjUC5V4dD0etpDCangGBU3jPNugQYwIcySa7B5fEr wkN1aBm5LK0MQAqeKYvvnJnLRk3HGDf04Qw1amOQWFytCt4fqjF1fvdt8EBlGOzL vakEFi4zpNeiaWk247SmtLBKdJVKyya7pWi798nzbzcEl37HLm1e1FlxaJRGpgfE QMCdftKbJe1wC6nFHvj8 =akRf -----END PGP SIGNATURE----- --qp4W5+cUSnZs0RIF--