From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, Ronnie Sahlberg <ronniesahlberg@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] iscsi: Translate scsi sense into error code
Date: Thu, 22 Oct 2015 17:51:47 +0800 [thread overview]
Message-ID: <20151022095147.GA3850@ad.usersys.redhat.com> (raw)
In-Reply-To: <5628A239.8030600@redhat.com>
On Thu, 10/22 10:45, Paolo Bonzini wrote:
>
>
> On 22/10/2015 10:31, Peter Lieven wrote:
> >
> > + switch (sense->key) {
> > + case SCSI_SENSE_NO_SENSE:
> > + return 0;
> > + break;
> > + case SCSI_SENSE_NOT_READY:
> > + return -EBUSY;
> > + break;
> > + case SCSI_SENSE_DATA_PROTECTION:
> > + return -EACCES;
>
> Probably EPERM, not EACCES.
The comment of bdrv_write says -EACCES for read-only device, shoudn't this be
the same?
Fam
next prev parent reply other threads:[~2015-10-22 9:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 8:17 [Qemu-devel] [PATCH 0/2] Fix werror=enospc for qcow2 on iscsi Fam Zheng
2015-10-22 8:17 ` [Qemu-devel] [PATCH 1/2] iscsi: Translate scsi sense into error code Fam Zheng
2015-10-22 8:31 ` Peter Lieven
2015-10-22 8:45 ` Paolo Bonzini
2015-10-22 9:11 ` Peter Lieven
2015-10-22 9:51 ` Fam Zheng [this message]
2015-10-22 9:56 ` Paolo Bonzini
2015-10-22 9:11 ` Kevin Wolf
2015-10-22 8:17 ` [Qemu-devel] [PATCH 2/2] qcow2: Translate -ERANGE to -ENOSPC Fam Zheng
2015-10-22 8:32 ` [Qemu-devel] [PATCH 0/2] Fix werror=enospc for qcow2 on iscsi Peter Lieven
2015-10-22 10:06 ` Fam Zheng
2015-10-22 8:45 ` Paolo Bonzini
2015-10-22 9:03 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022095147.GA3850@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).