From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpEMc-0001zy-UA for qemu-devel@nongnu.org; Thu, 22 Oct 2015 07:48:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpEMY-0002e8-2K for qemu-devel@nongnu.org; Thu, 22 Oct 2015 07:48:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpEMX-0002dd-TA for qemu-devel@nongnu.org; Thu, 22 Oct 2015 07:48:53 -0400 Date: Thu, 22 Oct 2015 14:48:50 +0300 From: "Michael S. Tsirkin" Message-ID: <20151022144537-mutt-send-email-mst@redhat.com> References: <1445510291-8764-1-git-send-email-matthias.lange@kernkonzept.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1445510291-8764-1-git-send-email-matthias.lange@kernkonzept.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] i386/acpi: add _HID to processor nodes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matthias Lange Cc: imammedo@redhat.com, rth@twiddle.net, qemu-devel@nongnu.org, ehabkost@redhat.com, pbonzini@redhat.com On Thu, Oct 22, 2015 at 12:38:11PM +0200, Matthias Lange wrote: > Processor nodes created via the acpi/aml framework currently don't > feature a _HID string. This patch appends "ACPI0007" as the _HID > string to each processor node. >=20 > Signed-off-by: Matthias Lange Indeed, it does that. But why? ACPI0007 Processor Device. This device provides an alternative to declaring processors using the Processor ASL statement. And =E2=80=9CDeclaring Processors=E2=80=9D says Each processor in the system must be declared in the ACPI namespace in either the \_SB or \_PR scope but not both. Declaration of processors in the \_PR scope is required for platforms desiring compatibility with ACPI 1.0-based OSPM implementations. Processors are declared either via the ASL Processor statement or the ASL Device statement. A Processor definition declares a processor object that provides processor configuration information and points to the processor register block (P_BLK). A Device definition for a processor is declared using the ACPI0007 hardware identifier (HID). In this case, processor configuration information is provided exclusively by objects in the processor device=E2=80=99s object list. In other words, Processor directive does not need a HID. In fact, ACPI 1.0 didn't include the ACPI0007 HID at all. Please include this info in both the commit log and a code comment. > --- > hw/i386/acpi-build.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 95e0c65..95f7bf9 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -1153,6 +1153,7 @@ build_ssdt(GArray *table_data, GArray *linker, > for (i =3D 0; i < acpi_cpus; i++) { > dev =3D aml_processor(i, 0, 0, "CP%.02X", i); > =20 > + aml_append(dev, aml_name_decl("_HID", aml_string("ACPI0007= "))); > method =3D aml_method("_MAT", 0); > aml_append(method, aml_return(aml_call1("CPMA", aml_int(i)= ))); > aml_append(dev, method); > --=20 > 1.9.1