qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 08/21] block: Compute minimum, maximum and average I/O latencies
Date: Fri, 23 Oct 2015 14:23:51 +0100	[thread overview]
Message-ID: <20151023132351.GA5977@stefanha-x1.localdomain> (raw)
In-Reply-To: <41aecf1556c3d1c05eca977d5b5644084b7f3496.1445500464.git.berto@igalia.com>

On Thu, Oct 22, 2015 at 11:11:18AM +0300, Alberto Garcia wrote:
> +struct BlockAcctTimedStats {
> +    TimedAverage latency[BLOCK_MAX_IOTYPE];
> +    unsigned interval_length;

/* in seconds */ would be nice here so the units are clear.  Or even
interval_length_secs.

  reply	other threads:[~2015-10-23 13:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22  8:11 [Qemu-devel] [PATCH v3 00/21] Extended I/O accounting Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 01/21] xen_disk: Account for flush operations Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 02/21] ide: Account for write operations correctly Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 03/21] block: define 'clock_type' for the accounting code Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 04/21] util: Infrastructure for computing recent averages Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 05/21] block: Add idle_time_ns to BlockDeviceStats Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 06/21] block: Add statistics for failed and invalid I/O operations Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 07/21] block: Allow configuring whether to account failed and invalid ops Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 08/21] block: Compute minimum, maximum and average I/O latencies Alberto Garcia
2015-10-23 13:23   ` Stefan Hajnoczi [this message]
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 09/21] block: Add average I/O queue depth to BlockDeviceTimedStats Alberto Garcia
2015-10-23 13:31   ` Stefan Hajnoczi
2015-10-23 13:47     ` Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 10/21] block: New option to define the intervals for collecting I/O statistics Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 11/21] qemu-io: Account for failed, invalid and flush operations Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 12/21] block: Use QEMU_CLOCK_VIRTUAL for the accounting code in qtest mode Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 13/21] iotests: Add test for the block device statistics Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 14/21] nvme: Account for failed and invalid operations Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 15/21] virtio-blk: " Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 16/21] xen_disk: " Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 17/21] atapi: " Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 18/21] ide: " Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 19/21] macio: Account for failed operations Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 20/21] scsi-disk: " Alberto Garcia
2015-10-22  8:11 ` [Qemu-devel] [PATCH v3 21/21] block: Update copyright of the accounting code Alberto Garcia
2015-10-23 14:00 ` [Qemu-devel] [PATCH v3 00/21] Extended I/O accounting Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151023132351.GA5977@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).