From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41926)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1ZpcK8-0008NC-8x
	for qemu-devel@nongnu.org; Fri, 23 Oct 2015 09:24:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1ZpcK7-0005iI-J9
	for qemu-devel@nongnu.org; Fri, 23 Oct 2015 09:24:00 -0400
Date: Fri, 23 Oct 2015 14:23:51 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20151023132351.GA5977@stefanha-x1.localdomain>
References: <cover.1445500464.git.berto@igalia.com>
	<41aecf1556c3d1c05eca977d5b5644084b7f3496.1445500464.git.berto@igalia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <41aecf1556c3d1c05eca977d5b5644084b7f3496.1445500464.git.berto@igalia.com>
Subject: Re: [Qemu-devel] [PATCH v3 08/21] block: Compute minimum,
 maximum and average I/O latencies
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>

On Thu, Oct 22, 2015 at 11:11:18AM +0300, Alberto Garcia wrote:
> +struct BlockAcctTimedStats {
> +    TimedAverage latency[BLOCK_MAX_IOTYPE];
> +    unsigned interval_length;

/* in seconds */ would be nice here so the units are clear.  Or even
interval_length_secs.