From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zq19N-0006Yf-MC for qemu-devel@nongnu.org; Sat, 24 Oct 2015 11:54:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zq19J-0000Em-C1 for qemu-devel@nongnu.org; Sat, 24 Oct 2015 11:54:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zq19J-0000Ch-6e for qemu-devel@nongnu.org; Sat, 24 Oct 2015 11:54:29 -0400 Date: Sat, 24 Oct 2015 18:54:23 +0300 From: "Michael S. Tsirkin" Message-ID: <20151024185412-mutt-send-email-mst@redhat.com> References: <1445600164-17068-1-git-send-email-mst@redhat.com> <562AD352.5040009@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <562AD352.5040009@huawei.com> Subject: Re: [Qemu-devel] [PATCH] vhost-user-test: fix up rhel6 build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei Cc: Marcel Apfelbaum , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Yuanhan Liu , qemu-devel@nongnu.org On Sat, Oct 24, 2015 at 08:39:46AM +0800, Gonglei wrote: > On 2015/10/23 19:36, Michael S. Tsirkin wrote: > > Build on RHEL6 fails: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42875 > > > > Apparently unnamed unions couldn't use C99 named field initializers. > > Let's just name the payload union field. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > tests/vhost-user-test.c | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > Reviewed-by: Gonglei Tested-by would have more value :)