From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zq2ot-0002oa-B2 for qemu-devel@nongnu.org; Sat, 24 Oct 2015 13:41:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zq2oq-00032b-4x for qemu-devel@nongnu.org; Sat, 24 Oct 2015 13:41:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zq2op-00032X-W2 for qemu-devel@nongnu.org; Sat, 24 Oct 2015 13:41:28 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id AE837C0AF790 for ; Sat, 24 Oct 2015 17:41:27 +0000 (UTC) Date: Sat, 24 Oct 2015 20:41:25 +0300 From: "Michael S. Tsirkin" Message-ID: <20151024204001-mutt-send-email-mst@redhat.com> References: <1445612242-79172-1-git-send-email-imammedo@redhat.com> <1445612242-79172-7-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445612242-79172-7-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 06/19] pc: acpi: move SSDT part of memhp into a custom table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On Fri, Oct 23, 2015 at 04:57:09PM +0200, Igor Mammedov wrote: > + /* copy AML table into ACPI tables blob and patch header there */ > + g_array_append_vals(table_data, table->buf->data, table->buf->len); > + build_header(linker, table_data, > + (void *)(table_data->data + table_data->len - table->buf->len), > + "MHPT", table->buf->len, 2); > + free_aml_allocator(); > +} Why not just put this in an SSDT? And what guarantees that there won't be an MHPT table in a future version of the spec, conflicting with this use? -- MST