From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zq4gb-0008Mj-Kt for qemu-devel@nongnu.org; Sat, 24 Oct 2015 15:41:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zq4gY-00018D-FY for qemu-devel@nongnu.org; Sat, 24 Oct 2015 15:41:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55470) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zq4gY-00017c-9f for qemu-devel@nongnu.org; Sat, 24 Oct 2015 15:41:02 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 0341B8CF43 for ; Sat, 24 Oct 2015 19:41:01 +0000 (UTC) Date: Sat, 24 Oct 2015 22:40:59 +0300 From: "Michael S. Tsirkin" Message-ID: <20151024223944-mutt-send-email-mst@redhat.com> References: <1445612242-79172-1-git-send-email-imammedo@redhat.com> <1445612242-79172-16-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445612242-79172-16-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 15/19] pc: acpi: bump DSDT revision compliance to v2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On Fri, Oct 23, 2015 at 04:57:18PM +0200, Igor Mammedov wrote: > it turns on 64-bit integer handling in OSPM, which we could use > for writing simpler/smaller AML code. > Tested with Windows XP and Windows Server 2008, Linux: > * XP doesn't care about revision and continues to use 32 integers > and boots just fine with this change. > * WS 2008 and Linux - support rev2 and use 64-bit integers > > Signed-off-by: Igor Mammedov This is still planned, right? IIUC you didn't post any code that needs the 64 bit math. > --- > hw/i386/acpi-build.c | 2 +- > hw/i386/acpi-dsdt.dsl | 2 +- > hw/i386/q35-acpi-dsdt.dsl | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 8add4d9..c929540 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -1484,7 +1484,7 @@ build_dsdt(GArray *table_data, GArray *linker, AcpiMiscInfo *misc) > > memset(dsdt, 0, sizeof *dsdt); > build_header(linker, table_data, dsdt, "DSDT", > - misc->dsdt_size, 1); > + misc->dsdt_size, 2); > } > > static GArray * > diff --git a/hw/i386/acpi-dsdt.dsl b/hw/i386/acpi-dsdt.dsl > index 8dba096..6d46b36 100644 > --- a/hw/i386/acpi-dsdt.dsl > +++ b/hw/i386/acpi-dsdt.dsl > @@ -22,7 +22,7 @@ ACPI_EXTRACT_ALL_CODE AcpiDsdtAmlCode > DefinitionBlock ( > "acpi-dsdt.aml", // Output Filename > "DSDT", // Signature > - 0x01, // DSDT Compliance Revision > + 0x02, // DSDT Compliance Revision > "BXPC", // OEMID > "BXDSDT", // TABLE ID > 0x1 // OEM Revision > diff --git a/hw/i386/q35-acpi-dsdt.dsl b/hw/i386/q35-acpi-dsdt.dsl > index 7be7b37..ecefdec 100644 > --- a/hw/i386/q35-acpi-dsdt.dsl > +++ b/hw/i386/q35-acpi-dsdt.dsl > @@ -28,7 +28,7 @@ ACPI_EXTRACT_ALL_CODE Q35AcpiDsdtAmlCode > DefinitionBlock ( > "q35-acpi-dsdt.aml",// Output Filename > "DSDT", // Signature > - 0x01, // DSDT Compliance Revision > + 0x02, // DSDT Compliance Revision > "BXPC", // OEMID > "BXDSDT", // TABLE ID > 0x2 // OEM Revision > -- > 1.8.3.1