From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37898)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZqWZL-0003js-FT
	for qemu-devel@nongnu.org; Sun, 25 Oct 2015 21:27:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZqWZI-00075r-9j
	for qemu-devel@nongnu.org; Sun, 25 Oct 2015 21:27:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41403)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1ZqWZI-00075V-54
	for qemu-devel@nongnu.org; Sun, 25 Oct 2015 21:27:24 -0400
Date: Mon, 26 Oct 2015 09:27:20 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20151026012720.GA28904@ad.usersys.redhat.com>
References: <1445339117-16278-1-git-send-email-dgilbert@redhat.com>
	<20151023093235.GA23646@ad.usersys.redhat.com>
	<CAJSP0QXREX4Uefqq3P-kgc9WPrT19p8gz9OHxetb24wN+vHkQw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJSP0QXREX4Uefqq3P-kgc9WPrT19p8gz9OHxetb24wN+vHkQw@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] gdb command: qemu aios, qemu aiohandlers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On Fri, 10/23 11:09, Stefan Hajnoczi wrote:
> On Fri, Oct 23, 2015 at 10:32 AM, Fam Zheng <famz@redhat.com> wrote:
> > On Tue, 10/20 12:05, Dr. David Alan Gilbert (git) wrote:
> >> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >>
> >> Two new gdb commands are added:
> >>
> >>   qemu iohandlers
> >>
> >>      that dumps the list of waiting iohandlers, this is particularly
> >>      useful for trying to figure out where an incoming migration is
> >>      blocked.  For 'fd_coroutine_enter' cases we dump a full backtrace.
> >>
> >>   qemu aios
> >>      that dumps the qemu_aio_context list.
> >
> > I'd assume "qemu aios" is a command to print the list of AioContext instances
> > rather than handlers in a particular context (qemu_aio_context). How about
> > "qemu handlers"?
> 
> Seems fine to me but it would be useful to add an optional AioContext
> pointer argument.
> 
> That way the command prints qemu_aio_context by default but can also
> be used to inspect arbitrary AioContexts.
> 

That is a good idea.

Fam