From: Amit Shah <amit.shah@redhat.com>
To: "Li, Liang Z" <liang.z.li@intel.com>
Cc: "'qemu-block@nongnu.org'" <qemu-block@nongnu.org>,
"'quintela@redhat.com'" <quintela@redhat.com>,
"'qemu-devel@nongnu.org'" <qemu-devel@nongnu.org>,
"Wang, Yong Y" <yong.y.wang@intel.com>,
"'qemu-stable@nongnu.org'" <qemu-stable@nongnu.org>,
"'stefanha@redhat.com'" <stefanha@redhat.com>,
"Zhang, Yang Z" <yang.z.zhang@intel.com>,
'Paolo Bonzini' <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [v2 0/4] Fix long vm downtime during live migration
Date: Mon, 26 Oct 2015 11:39:36 +0530 [thread overview]
Message-ID: <20151026060936.GA29130@grmbl.mre> (raw)
In-Reply-To: <F2CBF3009FA73547804AE4C663CAB28E0197F127@shsmsx102.ccr.corp.intel.com>
On (Wed) 21 Oct 2015 [09:00:31], Li, Liang Z wrote:
> > > Some cleanup operations take long time during the pause and copy
> > > stage, especially with the KVM patch 3ea3b7fa9af067, do these
> > > operations after the completion of live migration can help to reduce
> > > VM
> > downtime.
> > >
> > > Ony the first patch changes the behavior, the rest 3 patches are for
> > > code cleanup.
> > >
> > > Changes:
> > > * Remove qemu_savevm_sate_cancel() in migrate_fd_cleanup()
> > > * Add 2 more patches for code clean up
> >
> > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Resend this mail.
Hi Liang,
I'm looking at this patchset; I did take a look at it in the past and
I couldn't map everything; I need more time to look at everything
here.
Definitely a more detailed commit log or comments would've helped.
But there's already a reviewed-by from Paolo, so I fully expect this
patch to be merged in 2.5.
Amit
next prev parent reply other threads:[~2015-10-26 6:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 5:46 [Qemu-devel] [v2 0/4] Fix long vm downtime during live migration Liang Li
2015-08-13 5:46 ` [Qemu-devel] [v2 1/4] migration: do cleanup operation after completion Liang Li
2015-08-13 5:46 ` [Qemu-devel] [v2 2/4] migration: rename qemu_savevm_state_cancel Liang Li
2015-08-13 5:46 ` [Qemu-devel] [v2 3/4] migration: rename cancel to cleanup in SaveVMHandles Liang Li
2015-08-13 5:46 ` [Qemu-devel] [v2 4/4] migration: code clean up Liang Li
2015-08-13 6:30 ` [Qemu-devel] [v2 0/4] Fix long vm downtime during live migration Paolo Bonzini
2015-10-09 8:56 ` Li, Liang Z
2015-10-21 9:00 ` Li, Liang Z
2015-10-26 6:09 ` Amit Shah [this message]
2015-10-26 8:27 ` Li, Liang Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026060936.GA29130@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=liang.z.li@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=yang.z.zhang@intel.com \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).