From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZqayX-0003rC-Q1 for qemu-devel@nongnu.org; Mon, 26 Oct 2015 02:09:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZqayW-0000vU-Sa for qemu-devel@nongnu.org; Mon, 26 Oct 2015 02:09:45 -0400 Date: Mon, 26 Oct 2015 11:39:36 +0530 From: Amit Shah Message-ID: <20151026060936.GA29130@grmbl.mre> References: <1439444796-22862-1-git-send-email-liang.z.li@intel.com> <55CC3986.5060908@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [v2 0/4] Fix long vm downtime during live migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Li, Liang Z" Cc: "'qemu-block@nongnu.org'" , "'quintela@redhat.com'" , "'qemu-devel@nongnu.org'" , "Wang, Yong Y" , "'qemu-stable@nongnu.org'" , "'stefanha@redhat.com'" , "Zhang, Yang Z" , 'Paolo Bonzini' On (Wed) 21 Oct 2015 [09:00:31], Li, Liang Z wrote: > > > Some cleanup operations take long time during the pause and copy > > > stage, especially with the KVM patch 3ea3b7fa9af067, do these > > > operations after the completion of live migration can help to reduce > > > VM > > downtime. > > > > > > Ony the first patch changes the behavior, the rest 3 patches are for > > > code cleanup. > > > > > > Changes: > > > * Remove qemu_savevm_sate_cancel() in migrate_fd_cleanup() > > > * Add 2 more patches for code clean up > > > > Reviewed-by: Paolo Bonzini > > Resend this mail. Hi Liang, I'm looking at this patchset; I did take a look at it in the past and I couldn't map everything; I need more time to look at everything here. Definitely a more detailed commit log or comments would've helped. But there's already a reviewed-by from Paolo, so I fully expect this patch to be merged in 2.5. Amit