From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: amulya.lokesha@emc.com, jcody@redhat.com, qemu-devel@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] vhdx: Return true for bdrv_has_zero_init
Date: Mon, 26 Oct 2015 10:43:56 +0000 [thread overview]
Message-ID: <20151026104356.GC20111@stefanha-x1.localdomain> (raw)
In-Reply-To: <20151023160052.GO3797@noname.redhat.com>
On Fri, Oct 23, 2015 at 06:00:52PM +0200, Kevin Wolf wrote:
> Am 23.10.2015 um 17:32 hat Stefan Hajnoczi geschrieben:
> > On Fri, Dec 05, 2014 at 11:26:49AM +0100, Kevin Wolf wrote:
> > > Like for most other image formats, vhdx images read as all zero in qemu
> > > after their creation (we're taking advantage from the fact that qemu has
> > > just created the image, because PAYLOAD_BLOCK_NOT_PRESENT actually means
> > > undefined rather than zeroed according to the spec).
> > >
> > > This fixes that 'qemu-img convert' to vhdx fully populates the image.
> > >
> > > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > > ---
> > > block/vhdx.c | 1 +
> > > 1 file changed, 1 insertion(+)
> >
> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> Hasn't this been implemented in commit 85b712c9 almost a year ago?
Yes :).
I was cleaning out my inbox and didn't notice the date until after
replying.
prev parent reply other threads:[~2015-10-26 10:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 10:26 [Qemu-devel] [PATCH] vhdx: Return true for bdrv_has_zero_init Kevin Wolf
2014-12-05 11:06 ` Max Reitz
2014-12-05 11:07 ` Kevin Wolf
2014-12-05 14:35 ` Jeff Cody
2014-12-05 11:49 ` Kevin Wolf
2014-12-05 14:34 ` Jeff Cody
2015-10-23 15:32 ` Stefan Hajnoczi
2015-10-23 16:00 ` Kevin Wolf
2015-10-26 10:43 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026104356.GC20111@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=amulya.lokesha@emc.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).