From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53657)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1ZqgB7-00050h-1P
	for qemu-devel@nongnu.org; Mon, 26 Oct 2015 07:43:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1ZqgB3-0007Ec-R2
	for qemu-devel@nongnu.org; Mon, 26 Oct 2015 07:43:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36860)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1ZqgB3-0007Dg-Lf
	for qemu-devel@nongnu.org; Mon, 26 Oct 2015 07:43:01 -0400
Date: Mon, 26 Oct 2015 11:42:55 +0000
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20151026114254.GB2500@work-vm>
References: <1443515898-3594-1-git-send-email-dgilbert@redhat.com>
	<1443515898-3594-20-git-send-email-dgilbert@redhat.com>
	<87fv15vkyk.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87fv15vkyk.fsf@neno.neno>
Subject: Re: [Qemu-devel] [PATCH v8 19/54] Return path: Control commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: aarcange@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, bharata@linux.vnet.ibm.com, amit.shah@redhat.com, pbonzini@redhat.com

* Juan Quintela (quintela@redhat.com) wrote:
> "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> > Add two src->dest commands:
> >    * OPEN_RETURN_PATH - To request that the destination open the return path
> >    * PING - Request an acknowledge from the destination
> >
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > Reviewed-by: Amit Shah <amit.shah@redhat.com>
> 
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> 
> 
> > +void qemu_savevm_send_open_return_path(QEMUFile *f)
> > +{
> > +    qemu_savevm_command_send(f, MIG_CMD_OPEN_RETURN_PATH, 0, NULL);
> 
> 
> For consistency, I would have put a
> 
>        trace_savevm_send_open_return_path(....) here
> 
> The send in the loadvm path

Done.

Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK