From: "Michael S. Tsirkin" <mst@redhat.com>
To: Bharata B Rao <bharata@linux.vnet.ibm.com>
Cc: imammedo@redhat.com, qemu-devel@nongnu.org, david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH v2 0/2] Enforce gaps between DIMMs
Date: Mon, 26 Oct 2015 12:21:52 +0200 [thread overview]
Message-ID: <20151026122003-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1445846438-7324-1-git-send-email-bharata@linux.vnet.ibm.com>
On Mon, Oct 26, 2015 at 01:30:36PM +0530, Bharata B Rao wrote:
> The suggested way to work around the virtio bug reported here
>
> http://lists.nongnu.org/archive/html/qemu-devel/2015-08/msg00522.html
>
> is to introduce gaps between DIMMs. Igor's patchset changes the pc-dimm
> auto-address assignment to introduce gaps and ues the same from pc memhp.
> This patchset does the same for sPAPR PowerPC.
>
> Before introducing the gap, ensure that memory hotplug region has enough
> room for alignment adjustment. We accommodate a max alignment of 256MB for
> each slot since sPAPR memory hotplug enforces an alignment requirement of
> 256MB on RAM size, maxmem and NUMA node mem sizes.
>
> This applies on David's spapr-next branch.
This is already creating problems on x86.
Instead of propagating this all over the place,
let's fix things properly to either
- handle requests that cross the DIMMs
or
- make sure guest physically contigious implies host virtually
contigious
> Changes in v2
> -------------
> - Minor rewording of patch description and code comment in 1/2.
>
> v1: http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg02414.html
> v0: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg00749.html
>
> Bharata B Rao (2):
> spapr: Accommadate alignment gaps in hotplug memory region
> spapr: Force gaps between DIMM's GPA
>
> hw/ppc/spapr.c | 23 ++++++++++++++++++-----
> 1 file changed, 18 insertions(+), 5 deletions(-)
>
> --
> 2.1.0
prev parent reply other threads:[~2015-10-26 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 8:00 [Qemu-devel] [PATCH v2 0/2] Enforce gaps between DIMMs Bharata B Rao
2015-10-26 8:00 ` [Qemu-devel] [PATCH v2 1/2] spapr: Accommadate alignment gaps in hotplug memory region Bharata B Rao
2015-10-26 8:00 ` [Qemu-devel] [PATCH v2 2/2] spapr: Force gaps between DIMM's GPA Bharata B Rao
2015-10-26 10:21 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026122003-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).