Re: [Qemu-devel] [PATCH 1/2] vl: trivial: minor tweaks to a max-cpu error msg

[Andrew Jones <drjones@redhat.com>]

On Tue, Oct 20, 2015 at 09:12:18AM +0200, Markus Armbruster wrote:
> Andrew Jones <drjones@redhat.com> writes:
> 
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > ---
> >  vl.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/vl.c b/vl.c
> > index 7c806a2428399..9a64b75ebbd24 100644
> > --- a/vl.c
> > +++ b/vl.c
> > @@ -4080,8 +4080,8 @@ int main(int argc, char **argv, char **envp)
> >  
> >      machine_class->max_cpus = machine_class->max_cpus ?: 1; /* Default to UP */
> >      if (max_cpus > machine_class->max_cpus) {
> > -        fprintf(stderr, "Number of SMP cpus requested (%d), exceeds max cpus "
> > -                "supported by machine `%s' (%d)\n", max_cpus,
> > +        fprintf(stderr, "Number of SMP CPUs requested (%d) exceeds max CPUs "
> > +                "supported by machine '%s' (%d)\n", max_cpus,
> >                  machine_class->name, machine_class->max_cpus);
> >          exit(1);
> >      }
> 
> While you're touching this, error_report(), please.
>

Good call. Eduardo, I'll send you a v2 now.

drew