From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34918)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZqghO-00044H-MM
	for qemu-devel@nongnu.org; Mon, 26 Oct 2015 08:16:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZqghN-00086e-LT
	for qemu-devel@nongnu.org; Mon, 26 Oct 2015 08:16:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60663)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1ZqghN-00086S-GC
	for qemu-devel@nongnu.org; Mon, 26 Oct 2015 08:16:25 -0400
Date: Mon, 26 Oct 2015 14:16:23 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20151026141445-mutt-send-email-mst@redhat.com>
References: <1444919965-4327-1-git-send-email-marcandre.lureau@redhat.com>
	<20151024224257-mutt-send-email-mst@redhat.com>
	<CAJ+F1CKiqTjUcwXYn-w-jNy4gpADbpXS34pt5pMuiWCk7b=xXA@mail.gmail.com>
	<20151026133045-mutt-send-email-mst@redhat.com>
	<CAJ+F1CLuZ9u179Vh6aYQyeoqFP-L1TVJyVQ8vavk91ZeZ6LBBw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <CAJ+F1CLuZ9u179Vh6aYQyeoqFP-L1TVJyVQ8vavk91ZeZ6LBBw@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] tests: re-enable vhost-user-test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>

On Mon, Oct 26, 2015 at 01:09:56PM +0100, Marc-Andr=E9 Lureau wrote:
> HI
>=20
> On Mon, Oct 26, 2015 at 12:38 PM, Michael S. Tsirkin <mst@redhat.com> w=
rote:
> > Like this then?
> >
> > if test target_name =3D=3D "i386" -o target_name =3D=3D "x86_64"
> > then
> >         echo "CONFIG_VHOST_NET_TEST_$target_name=3Dy" >> $config_host=
_mak
> > fi
> >
> >
> > ifeq ($(CONFIG_VHOST_NET_i386),y)
> > check-qtest-i386-y +=3D tests/vhost-user-test$(EXESUF)
> > endif
> > ifeq ($(CONFIG_VHOST_NET_x86_64),y)
> > check-qtest-x86_64-y +=3D tests/vhost-user-test$(EXESUF)
> > endif
> >
>=20
> I think I understand your idea, but it looks verbose, you are missing
> the arm case,

We didn't previously support vhost-user-test on ARM,
adding that seems like a separate project.
In fact adding x86_64 might best be done in
a separate patch.


> and I don't have a good way to test it.
> >>
> >> I don't feel very confortable with that sort of per-host/per-target
> >> complex configure-time conditions. I would rather simply use a simpl=
e
> >> runtime test check such as:
> >
> > Problem with runtime checks is it makes people not notice
> > there's a problem.
>=20
> fair enough
>=20
>=20
> --=20
> Marc-Andr=E9 Lureau