From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56164)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Zql0C-0001Rn-U4
	for qemu-devel@nongnu.org; Mon, 26 Oct 2015 12:52:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Zql0C-0007UF-4r
	for qemu-devel@nongnu.org; Mon, 26 Oct 2015 12:52:08 -0400
Date: Mon, 26 Oct 2015 17:51:59 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20151026165159.GI4044@noname.redhat.com>
References: <1445280546-26226-1-git-send-email-mreitz@redhat.com>
	<1445280546-26226-3-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1445280546-26226-3-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 2/6] block: Avoid
	BlockDriverState.filename
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org

Am 19.10.2015 um 20:49 hat Max Reitz geschrieben:
> In places which directly pass a filename to the OS, we should not use
> the filename field at all but exact_filename instead (although the
> former currently equals the latter if that is set).
> 
> In raw_open_common(), we do not need to access BDS.filename because we
> already have a local variable pointing to the filename.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>

> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index 918c756..9cb7ebd 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -505,7 +505,7 @@ static int raw_open_common(BlockDriverState *bs, QDict *options,
>                       "specified. Falling back to aio=threads.\n"
>                       "         This will become an error condition in "
>                       "future QEMU versions.\n",
> -                     bs->filename);
> +                     filename);
>      }
>  #else
>      if (bdrv_flags & BDRV_O_NATIVE_AIO) {

           error_printf("WARNING: aio=native was specified for '%s', but "
                        "is not supported in this build. Falling back to "
                        "aio=threads.\n"
                        "         This will become an error condition in "
                        "future QEMU versions.\n",
                        bs->filename);
       }

That's another instance that should be changed.

Kevin