From: "Daniel P. Berrange" <berrange@redhat.com>
To: Yang Hongyang <hongyang.yang@easystack.cn>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] vnc: fix bug: vnc server can't start when 'to' is specified
Date: Tue, 27 Oct 2015 16:25:55 +0900 [thread overview]
Message-ID: <20151027072555.GA3167@redhat.com> (raw)
In-Reply-To: <1445926252-14830-1-git-send-email-hongyang.yang@easystack.cn>
On Tue, Oct 27, 2015 at 02:10:52PM +0800, Yang Hongyang wrote:
> commit e0d03b8ceb52 converted VNC startup to use SocketAddress,
> the interface socket_listen don't have a port_offset param, so
> we need to add the port offset (5900) to both 'port' and 'to' opts.
> currently only 'port' is added by offset.
> This patch add the port offset to 'to' opts.
>
> Signed-off-by: Yang Hongyang <hongyang.yang@easystack.cn>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Cc: Eric Blake <eblake@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2015-10-27 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 6:10 [Qemu-devel] [PATCH] vnc: fix bug: vnc server can't start when 'to' is specified Yang Hongyang
2015-10-27 7:25 ` Daniel P. Berrange [this message]
2015-10-28 14:43 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027072555.GA3167@redhat.com \
--to=berrange@redhat.com \
--cc=hongyang.yang@easystack.cn \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).