From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqye2-00026n-91 for qemu-devel@nongnu.org; Tue, 27 Oct 2015 03:26:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zqydz-0000pe-3l for qemu-devel@nongnu.org; Tue, 27 Oct 2015 03:26:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zqydy-0000pR-UT for qemu-devel@nongnu.org; Tue, 27 Oct 2015 03:26:07 -0400 Date: Tue, 27 Oct 2015 16:25:55 +0900 From: "Daniel P. Berrange" Message-ID: <20151027072555.GA3167@redhat.com> References: <1445926252-14830-1-git-send-email-hongyang.yang@easystack.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1445926252-14830-1-git-send-email-hongyang.yang@easystack.cn> Subject: Re: [Qemu-devel] [PATCH] vnc: fix bug: vnc server can't start when 'to' is specified Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang Cc: qemu-devel@nongnu.org, Gerd Hoffmann On Tue, Oct 27, 2015 at 02:10:52PM +0800, Yang Hongyang wrote: > commit e0d03b8ceb52 converted VNC startup to use SocketAddress, > the interface socket_listen don't have a port_offset param, so > we need to add the port offset (5900) to both 'port' and 'to' opts. > currently only 'port' is added by offset. > This patch add the port offset to 'to' opts. > > Signed-off-by: Yang Hongyang > Cc: Daniel P. Berrange > Cc: Eric Blake > Cc: Gerd Hoffmann Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|