qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: Andrey Korolyov <andrey@xdel.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	ehabkost@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] pc: memhp: enforce minimal 128Mb alignment for pc-dimm
Date: Tue, 27 Oct 2015 08:39:57 +0100	[thread overview]
Message-ID: <20151027083957.0b21e318@nial.brq.redhat.com> (raw)
In-Reply-To: <CABYiri-pxN3Z+dkYy6d49x9iFMT4xcmKreqhRwmSbUFZVxoD4g@mail.gmail.com>

On Mon, 26 Oct 2015 21:42:05 +0300
Andrey Korolyov <andrey@xdel.ru> wrote:

> > How about following comment:
> > /* Linux guests expect 512/64/128Mb alignment for PAE/x32/x64 arch
> >  * respectively. Windows works fine with 2Mb. To make sure that
> >  * memory hotplug would work with above flavors of Linux set
> >  * minimal alignment to 512Mb (i.e. PAE arch).
> >  * Enforcing minimal alignment bigger than that of a backend
> >  * (2Mb for memory-backend-ram) changes GPAs of the 2nd and
> >  * following DIMMs which breaks migration for older machine types,
> >  * so force minimal alignment only since 2.5 machine type and do not
> >  * apply it to older machine types (prior 2.5)
> >  */
> >
> 
> 
> PAE guests are working with 128Mb alignment just fine, at least
> 3.8...3.16 I`ve tried previously, have you seen a counter-example?

Issue is seen only during unplug when DIMM is not aligned to 
SECTION_SIZE_BITS.

  reply	other threads:[~2015-10-27  7:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26  9:46 [Qemu-devel] [PATCH v2] pc: memhp: enforce minimal 128Mb alignment for pc-dimm Igor Mammedov
2015-10-26 10:28 ` Michael S. Tsirkin
2015-10-26 13:24   ` Igor Mammedov
2015-10-26 18:42     ` Andrey Korolyov
2015-10-27  7:39       ` Igor Mammedov [this message]
2015-10-27  8:31     ` Michael S. Tsirkin
2015-10-27  8:48       ` Igor Mammedov
2015-10-27  8:53         ` Michael S. Tsirkin
2015-10-27  9:14           ` Igor Mammedov
2015-10-27 16:36             ` Eduardo Habkost
2015-10-29 13:36               ` Igor Mammedov
2015-10-29 18:16                 ` [Qemu-devel] RAM backend and guest ABI (was Re: [PATCH v2] pc: memhp: enforce minimal 128Mb) " Eduardo Habkost
2015-10-30 13:07                   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151027083957.0b21e318@nial.brq.redhat.com \
    --to=imammedo@redhat.com \
    --cc=andrey@xdel.ru \
    --cc=ehabkost@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).