From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39130) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr09D-000566-Qj for qemu-devel@nongnu.org; Tue, 27 Oct 2015 05:02:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr095-0006tW-TR for qemu-devel@nongnu.org; Tue, 27 Oct 2015 05:02:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50774) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr095-0006tM-Np for qemu-devel@nongnu.org; Tue, 27 Oct 2015 05:02:19 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id D168DA3030 for ; Tue, 27 Oct 2015 09:02:18 +0000 (UTC) Date: Tue, 27 Oct 2015 11:02:16 +0200 From: "Michael S. Tsirkin" Message-ID: <20151027110133-mutt-send-email-mst@redhat.com> References: <1445604926-65453-1-git-send-email-imammedo@redhat.com> <20151027084231.3200260a@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151027084231.3200260a@nial.brq.redhat.com> Subject: Re: [Qemu-devel] [PATCH] pc: memhp: do not emit inserting event for coldplugged DIMMs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org On Tue, Oct 27, 2015 at 08:42:31AM +0100, Igor Mammedov wrote: > On Fri, 23 Oct 2015 14:55:26 +0200 > Igor Mammedov wrote: > > > currently acpi_memory_plug_cb() sets is_inserting for > > cold- and hot-plugged DIMMs as result ASL MHPD.MSCN() > > method issues device check even for every coldplugged > > DIMM. There isn't much harm in it but if we try to > > unplug such DIMM, OSPM will issue device check > > intstead of device eject event. So OSPM won't eject > > memory module as expected and it will try to eject it > > only when another memory device is hot-(un)plugged. > > > > As a fix do not set 'is_inserting' event and do not > > issue SCI for cold-plugged DIMMs as they are > > enumerated and activated by OSPM during guest's boot. > > > > Signed-off-by: Igor Mammedov > ping It's only been 4 days, 2 out of these a weekend. Sit tight please, give people time to review. > > --- > > hw/acpi/memory_hotplug.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c > > index 2ff0d5c..ce428df 100644 > > --- a/hw/acpi/memory_hotplug.c > > +++ b/hw/acpi/memory_hotplug.c > > @@ -238,10 +238,12 @@ void acpi_memory_plug_cb(ACPIREGS *ar, qemu_irq irq, MemHotplugState *mem_st, > > > > mdev->dimm = dev; > > mdev->is_enabled = true; > > - mdev->is_inserting = true; > > + if (dev->hotplugged) { > > + mdev->is_inserting = true; > > > > - /* do ACPI magic */ > > - acpi_send_gpe_event(ar, irq, ACPI_MEMORY_HOTPLUG_STATUS); > > + /* do ACPI magic */ > > + acpi_send_gpe_event(ar, irq, ACPI_MEMORY_HOTPLUG_STATUS); > > + } > > return; > > } > >