From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr31T-0003Qg-FR for qemu-devel@nongnu.org; Tue, 27 Oct 2015 08:06:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr31Q-0006vo-7y for qemu-devel@nongnu.org; Tue, 27 Oct 2015 08:06:39 -0400 Received: from e06smtp07.uk.ibm.com ([195.75.94.103]:56202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr31P-0006v3-Vo for qemu-devel@nongnu.org; Tue, 27 Oct 2015 08:06:36 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 27 Oct 2015 12:06:33 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 580891B0805F for ; Tue, 27 Oct 2015 12:06:40 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t9RC6TwA51708042 for ; Tue, 27 Oct 2015 12:06:29 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t9RC6T3I018253 for ; Tue, 27 Oct 2015 06:06:29 -0600 Date: Tue, 27 Oct 2015 13:06:27 +0100 From: Cornelia Huck Message-ID: <20151027130627.5af3a152.cornelia.huck@de.ibm.com> In-Reply-To: <1445935663-31971-1-git-send-email-mst@redhat.com> References: <1445935663-31971-1-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/6] virtio: handle non contigious s/g entries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Igor Mammedov , qemu-devel@nongnu.org On Tue, 27 Oct 2015 10:47:54 +0200 "Michael S. Tsirkin" wrote: > TL;DR: > This fixes virtio in a way transparent to guest. > We should now be able to revert commits aa8580cd and df0acded19ec which w= orked > around it in a way that's not transparent. (...) > Michael S. Tsirkin (6): > virtio: introduce virtio_map > virtio: switch to virtio_map > virtio-blk: convert to virtqueue_map > virtio-serial: convert to virtio_map > virtio-scsi: convert to virtqueue_map > virtio: drop virtqueue_map_sg >=20 > include/hw/virtio/virtio.h | 3 +-- > hw/block/virtio-blk.c | 5 +---- > hw/char/virtio-serial-bus.c | 5 +---- > hw/scsi/virtio-scsi.c | 16 ++------------ > hw/virtio/virtio.c | 52 +++++++++++++++++++++++++++++++++++----= ------ > 5 files changed, 46 insertions(+), 35 deletions(-) Does not compile for me on s390: /home/cohuck/git/qemu/hw/virtio/virtio.c: In function =E2=80=98virtqueue_ma= p=E2=80=99: /home/cohuck/git/qemu/hw/virtio/virtio.c:498:25: error: passing argument 3 = of =E2=80=98virtqueue_map_iovec=E2=80=99 from incompatible pointer type [-W= error] 1); ^ /home/cohuck/git/qemu/hw/virtio/virtio.c:451:13: note: expected =E2=80=98si= ze_t *=E2=80=99 but argument is of type =E2=80=98unsigned int *=E2=80=99 static void virtqueue_map_iovec(struct iovec *sg, hwaddr *addr, ^ /home/cohuck/git/qemu/hw/virtio/virtio.c:501:25: error: passing argument 3 = of =E2=80=98virtqueue_map_iovec=E2=80=99 from incompatible pointer type [-W= error] 0); ^ /home/cohuck/git/qemu/hw/virtio/virtio.c:451:13: note: expected =E2=80=98si= ze_t *=E2=80=99 but argument is of type =E2=80=98unsigned int *=E2=80=99 static void virtqueue_map_iovec(struct iovec *sg, hwaddr *addr, ^