From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56030) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr6Vi-0003Sc-3q for qemu-devel@nongnu.org; Tue, 27 Oct 2015 11:50:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr6Vc-0004xw-Dw for qemu-devel@nongnu.org; Tue, 27 Oct 2015 11:50:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr6Vc-0004xs-8w for qemu-devel@nongnu.org; Tue, 27 Oct 2015 11:50:00 -0400 Date: Tue, 27 Oct 2015 17:49:57 +0200 From: "Michael S. Tsirkin" Message-ID: <20151027174900-mutt-send-email-mst@redhat.com> References: <1445869920-6029-1-git-send-email-marcandre.lureau@redhat.com> <1889109701.37758961.1445956406827.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1889109701.37758961.1445956406827.JavaMail.zimbra@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCHv2] tests: re-enable vhost-user-test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: Peter Maydell , QEMU Developers , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau On Tue, Oct 27, 2015 at 10:33:26AM -0400, Marc-Andr=E9 Lureau wrote: > Hi >=20 > ----- Original Message ----- > > On 26 October 2015 at 14:32, wrote: > > > From: Marc-Andr=E9 Lureau > > > > > > Commit 7fe34ca9c2e actually disabled vhost-user-test altogether, > > > since CONFIG_VHOST_NET is a per-target config variable. > > > > > > tests/vhost-user-test is already x86/x64 softmmu specific test, in = order > > > to enable it correctly, kvm & vhost-net are also conditions. To che= ck > > > that, set CONFIG_VHOST_NET_TEST_$target when kvm is also enabled. > > > > > > Since "check-qtest-x86_64-y =3D $(check-qtest-i386-y)", avoid dupli= cation > > > when both x86 & x64 are enabled. > > > > > > Other targets than x86 aren't enabled yet, and is intentionally lef= t as > > > a future improvement, since I can't easily test those. > > > > > > Signed-off-by: Marc-Andr=E9 Lureau > >=20 > > I ran this through my build-tests, which pass, but: > >=20 > > (a) there's still the clang warning about the negative shifts > > in target-i386/. This is an ancient bug and we can fix it later. >=20 > I sent a patch to fix this. >=20 > > (b) there are new warning messages: > > Warning: path not on HugeTLBFS: /tmp/vhost-test-xaGJRK > > Warning: path not on HugeTLBFS: /tmp/vhost-test-xaGJRK > > Warning: path not on HugeTLBFS: /tmp/vhost-test-xaGJRK >=20 > These are part of qemu file_ram_alloc() >=20 > > I would like (b) fixed -- tests should either: > > (1) complete without printing "warning" about anything >=20 > We would need to change the qemu warning. Rather, disable it if running under test. > > (2) fail the test if the warning is actually important > > (3) skip the test if the test requires something that the host > > machine doesn't have (like a hugetlbfs) >=20 > It is not important for the test to succeed. >=20 > I imagine a few options to get rid of the warning: > 1. only run the test on hugetlbfs > 2. remove the warning from qemu > 3. silence qemu errors in the test > 4. add an option to memory-backend-file to require hugetlbfs: something= like ...,require-hugetlbfs=3Dtrue,false,warn >=20 > I guess 4. is the most interesting, although I would need some advice o= n how to express this best. >=20 > (tbh, I think this could be addressed later) Well not annoying people is important, otherwise they stop paying attention to warnings. --=20 MST