From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49005)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ZrNOR-0005Kx-Nr
	for qemu-devel@nongnu.org; Wed, 28 Oct 2015 05:51:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ZrNOQ-0003YZ-PH
	for qemu-devel@nongnu.org; Wed, 28 Oct 2015 05:51:43 -0400
Date: Wed, 28 Oct 2015 10:51:34 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20151028095134.GC3836@noname.str.redhat.com>
References: <1445840693-3177-1-git-send-email-famz@redhat.com>
	<1445840693-3177-5-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1445840693-3177-5-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/9] iscsi: Emulate commands in
 iscsi_aio_ioctl as iscsi_ioctl
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>, qemu-block@nongnu.org, Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org, Ronnie Sahlberg <ronniesahlberg@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>

Am 26.10.2015 um 07:24 hat Fam Zheng geschrieben:
> iscsi_ioctl emulates SG_GET_VERSION_NUM and SG_GET_SCSI_ID. Now that
> bdrv_ioctl() will be emulated with .bdrv_aio_ioctl, replicate the logic
> into iscsi_aio_ioctl to make them consistent.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  block/iscsi.c | 39 +++++++++++++++++++++++++++++++++++++--
>  1 file changed, 37 insertions(+), 2 deletions(-)
> 
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 93f1ee4..94cbdf2 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -96,6 +96,7 @@ typedef struct IscsiAIOCB {
>      int status;
>      int64_t sector_num;
>      int nb_sectors;
> +    int ret;
>  #ifdef __linux__
>      sg_io_hdr_t *ioh;
>  #endif
> @@ -726,6 +727,37 @@ iscsi_aio_ioctl_cb(struct iscsi_context *iscsi, int status,
>      iscsi_schedule_bh(acb);
>  }
>  
> +static void iscsi_ioctl_bh_completion(void *opaque)
> +{
> +    IscsiAIOCB *acb = opaque;
> +
> +    qemu_bh_delete(acb->bh);
> +    acb->common.cb(acb->common.opaque, acb->ret);
> +}

qemu_aio_unref(acb)?

Kevin