From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org, Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/9] block: Fixes for bdrv_drain
Date: Wed, 28 Oct 2015 11:16:33 +0100 [thread overview]
Message-ID: <20151028101633.GF3836@noname.str.redhat.com> (raw)
In-Reply-To: <1445840693-3177-1-git-send-email-famz@redhat.com>
Am 26.10.2015 um 07:24 hat Fam Zheng geschrieben:
> Previously bdrv_drain and bdrv_drain_all don't handle ioctl, flush and discard
> requests (which are fundamentally the same as read and write requests that
> change disk state). Forgetting such requests leaves us in risk of violating
> the invariant that bdrv_drain() callers rely on - all asynchronous requests
> must have completed after bdrv_drain returns.
>
> Enrich the tracked request types, and add tracked_request_begin/end pairs to
> all three code paths. As a prerequisite, ioctl code is moved into coroutine
> too.
>
> The last two patches take care of QED's "need check" timer, so that after
> bdrv_drain returns, the driver is in a consistent state.
Patches 1-3, 5-7 and 9:
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
prev parent reply other threads:[~2015-10-28 10:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 6:24 [Qemu-devel] [PATCH 0/9] block: Fixes for bdrv_drain Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 1/9] block: Add more types for tracked request Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 2/9] block: Track flush requests Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 3/9] block: Track discard requests Fam Zheng
2015-10-28 9:54 ` Kevin Wolf
2015-10-29 1:34 ` Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 4/9] iscsi: Emulate commands in iscsi_aio_ioctl as iscsi_ioctl Fam Zheng
2015-10-28 9:51 ` Kevin Wolf
2015-10-29 1:35 ` Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 5/9] block: Add ioctl parameter fields to BlockRequest Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 6/9] block: Emulate bdrv_ioctl with bdrv_aio_ioctl and track both Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 7/9] block: Drop BlockDriver.bdrv_ioctl Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 8/9] block: Introduce BlockDriver.bdrv_drain callback Fam Zheng
2015-10-28 10:13 ` Kevin Wolf
2015-10-29 1:38 ` Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 9/9] qed: Implement .bdrv_drain Fam Zheng
2015-10-28 10:16 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151028101633.GF3836@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).