From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrNmm-0005YJ-5j for qemu-devel@nongnu.org; Wed, 28 Oct 2015 06:16:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrNmg-00022r-K1 for qemu-devel@nongnu.org; Wed, 28 Oct 2015 06:16:52 -0400 Date: Wed, 28 Oct 2015 11:16:33 +0100 From: Kevin Wolf Message-ID: <20151028101633.GF3836@noname.str.redhat.com> References: <1445840693-3177-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1445840693-3177-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/9] block: Fixes for bdrv_drain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Stefan Hajnoczi , qemu-block@nongnu.org, Peter Lieven , qemu-devel@nongnu.org, Ronnie Sahlberg , Paolo Bonzini Am 26.10.2015 um 07:24 hat Fam Zheng geschrieben: > Previously bdrv_drain and bdrv_drain_all don't handle ioctl, flush and discard > requests (which are fundamentally the same as read and write requests that > change disk state). Forgetting such requests leaves us in risk of violating > the invariant that bdrv_drain() callers rely on - all asynchronous requests > must have completed after bdrv_drain returns. > > Enrich the tracked request types, and add tracked_request_begin/end pairs to > all three code paths. As a prerequisite, ioctl code is moved into coroutine > too. > > The last two patches take care of QED's "need check" timer, so that after > bdrv_drain returns, the driver is in a consistent state. Patches 1-3, 5-7 and 9: Reviewed-by: Kevin Wolf