From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrQNx-0002xn-7W for qemu-devel@nongnu.org; Wed, 28 Oct 2015 09:03:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrQNr-0007eK-Lu for qemu-devel@nongnu.org; Wed, 28 Oct 2015 09:03:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrQNr-0007e9-HG for qemu-devel@nongnu.org; Wed, 28 Oct 2015 09:03:19 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 28F33C0A8490 for ; Wed, 28 Oct 2015 13:03:19 +0000 (UTC) Date: Wed, 28 Oct 2015 14:03:17 +0100 From: Igor Mammedov Message-ID: <20151028140317.1a195430@nial.brq.redhat.com> In-Reply-To: <1445935663-31971-5-git-send-email-mst@redhat.com> References: <1445935663-31971-1-git-send-email-mst@redhat.com> <1445935663-31971-5-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] virtio-serial: convert to virtio_map List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Amit Shah , Paolo Bonzini , qemu-devel@nongnu.org On Tue, 27 Oct 2015 10:48:03 +0200 "Michael S. Tsirkin" wrote: > This also fixes a minor bug: > - virtqueue_map_sg(port->elem.out_sg, port->elem.out_addr, > - port->elem.out_num, 1); > is wrong: out_sg is not written so should not be marked dirty. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov > --- > hw/char/virtio-serial-bus.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c > index be97058..497b0af 100644 > --- a/hw/char/virtio-serial-bus.c > +++ b/hw/char/virtio-serial-bus.c > @@ -705,10 +705,7 @@ static int fetch_active_ports_list(QEMUFile *f, int version_id, > > qemu_get_buffer(f, (unsigned char *)&port->elem, > sizeof(port->elem)); > - virtqueue_map_sg(port->elem.in_sg, port->elem.in_addr, > - port->elem.in_num, 1); > - virtqueue_map_sg(port->elem.out_sg, port->elem.out_addr, > - port->elem.out_num, 1); > + virtqueue_map(&port->elem); > > /* > * Port was throttled on source machine. Let's