From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrQOy-0004JY-SD for qemu-devel@nongnu.org; Wed, 28 Oct 2015 09:04:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrQOt-0007uH-Uy for qemu-devel@nongnu.org; Wed, 28 Oct 2015 09:04:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrQOt-0007uC-Pe for qemu-devel@nongnu.org; Wed, 28 Oct 2015 09:04:23 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 66D30A2C18 for ; Wed, 28 Oct 2015 13:04:23 +0000 (UTC) Date: Wed, 28 Oct 2015 14:04:21 +0100 From: Igor Mammedov Message-ID: <20151028140421.7115c46f@nial.brq.redhat.com> In-Reply-To: <1445935663-31971-7-git-send-email-mst@redhat.com> References: <1445935663-31971-1-git-send-email-mst@redhat.com> <1445935663-31971-7-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6] virtio: drop virtqueue_map_sg List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org On Tue, 27 Oct 2015 10:48:08 +0200 "Michael S. Tsirkin" wrote: > Deprecated in favor of virtqueue_map. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov > --- > include/hw/virtio/virtio.h | 2 -- > hw/virtio/virtio.c | 7 ------- > 2 files changed, 9 deletions(-) > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > index 9d9abb4..205fadf 100644 > --- a/include/hw/virtio/virtio.h > +++ b/include/hw/virtio/virtio.h > @@ -151,8 +151,6 @@ void virtqueue_discard(VirtQueue *vq, const VirtQueueElement *elem, > void virtqueue_fill(VirtQueue *vq, const VirtQueueElement *elem, > unsigned int len, unsigned int idx); > > -void virtqueue_map_sg(struct iovec *sg, hwaddr *addr, > - size_t num_sg, int is_write); > void virtqueue_map(VirtQueueElement *elem); > int virtqueue_pop(VirtQueue *vq, VirtQueueElement *elem); > int virtqueue_avail_bytes(VirtQueue *vq, unsigned int in_bytes, > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 84e2320..be32145 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -491,13 +491,6 @@ static void virtqueue_map_iovec(struct iovec *sg, hwaddr *addr, > } > } > > -/* Deprecated: don't use in new code */ > -void virtqueue_map_sg(struct iovec *sg, hwaddr *addr, > - size_t num_sg, int is_write) > -{ > - virtqueue_map_iovec(sg, addr, &num_sg, num_sg, is_write); > -} > - > void virtqueue_map(VirtQueueElement *elem) > { > virtqueue_map_iovec(elem->in_sg, elem->in_addr, &elem->in_num,