qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.5 0/2] trace: decrease overhead of simpletrace and stderr backends
Date: Wed, 28 Oct 2015 14:44:46 +0000	[thread overview]
Message-ID: <20151028144446.GA4708@stefanha-x1.localdomain> (raw)
In-Reply-To: <1446012388-9586-1-git-send-email-pbonzini@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

On Wed, Oct 28, 2015 at 07:06:25AM +0100, Paolo Bonzini wrote:
> This patch series makes it faster for simpletrace and stderr backends
> to discard disabled events.  This is done in two ways: patch 1 makes
> the common case of no enabled events faster; patch 2 makes the other
> case less heavy on the data cache by packing the "tracepoint enabled"
> flag and avoiding useless pointer chasing.
> 
> This should decrease the impact of changing the default tracing backend
> to stderr aka log, which Peter suggested could be a problem.
> 
> Paolo
> 
> Paolo Bonzini (2):
>   trace: count number of enabled events
>   trace: track enabled events in a separate array
> 
>  scripts/tracetool/format/events_c.py |  2 +-
>  trace/control-internal.h             | 15 ++++++++++++---
>  trace/control.c                      |  3 +++
>  trace/control.h                      |  2 +-
>  trace/event-internal.h               |  2 --
>  5 files changed, 17 insertions(+), 7 deletions(-)

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

      parent reply	other threads:[~2015-10-28 14:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28  6:06 [Qemu-devel] [PATCH for-2.5 0/2] trace: decrease overhead of simpletrace and stderr backends Paolo Bonzini
2015-10-28  6:06 ` [Qemu-devel] [PATCH 1/2] trace: count number of enabled events Paolo Bonzini
2015-10-28  6:06 ` [Qemu-devel] [PATCH 2/2] trace: track enabled events in a separate array Paolo Bonzini
2015-10-28 14:44 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151028144446.GA4708@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).