From: Fam Zheng <famz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org, Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/9] block: Track discard requests
Date: Thu, 29 Oct 2015 09:34:07 +0800 [thread overview]
Message-ID: <20151029013407.GA19696@ad.usersys.redhat.com> (raw)
In-Reply-To: <20151028095421.GD3836@noname.str.redhat.com>
On Wed, 10/28 10:54, Kevin Wolf wrote:
> > - return 0;
> > +out:
> > + tracked_request_end(&req);
> > + return ret;
> > }
>
> I would prefer an explicit ret = 0 before the out label because
> otherwise you're relying on the previous value that has been set
> somewhere in the loop. As far as I can tell, it's still correct, but it
> makes it needlessly hard to tell whether success is 0 or >= 0.
Good point, will fix.
Fam
next prev parent reply other threads:[~2015-10-29 1:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 6:24 [Qemu-devel] [PATCH 0/9] block: Fixes for bdrv_drain Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 1/9] block: Add more types for tracked request Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 2/9] block: Track flush requests Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 3/9] block: Track discard requests Fam Zheng
2015-10-28 9:54 ` Kevin Wolf
2015-10-29 1:34 ` Fam Zheng [this message]
2015-10-26 6:24 ` [Qemu-devel] [PATCH 4/9] iscsi: Emulate commands in iscsi_aio_ioctl as iscsi_ioctl Fam Zheng
2015-10-28 9:51 ` Kevin Wolf
2015-10-29 1:35 ` Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 5/9] block: Add ioctl parameter fields to BlockRequest Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 6/9] block: Emulate bdrv_ioctl with bdrv_aio_ioctl and track both Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 7/9] block: Drop BlockDriver.bdrv_ioctl Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 8/9] block: Introduce BlockDriver.bdrv_drain callback Fam Zheng
2015-10-28 10:13 ` Kevin Wolf
2015-10-29 1:38 ` Fam Zheng
2015-10-26 6:24 ` [Qemu-devel] [PATCH 9/9] qed: Implement .bdrv_drain Fam Zheng
2015-10-28 10:16 ` [Qemu-devel] [PATCH 0/9] block: Fixes for bdrv_drain Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151029013407.GA19696@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).