From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49970)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ZricT-00021T-Bu
	for qemu-devel@nongnu.org; Thu, 29 Oct 2015 04:31:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ZricS-0000jI-7A
	for qemu-devel@nongnu.org; Thu, 29 Oct 2015 04:31:37 -0400
Date: Thu, 29 Oct 2015 09:31:28 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20151029083128.GB3854@noname.redhat.com>
References: <20151028235824.GB663@redhat.com>
	<20151029081115.GA3854@noname.redhat.com>
	<20151029081520.GB32623@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151029081520.GB32623@redhat.com>
Subject: Re: [Qemu-devel] How to specify the full block driver tree on the
	CLI ?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: stefanha@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org

Am 29.10.2015 um 09:15 hat Daniel P. Berrange geschrieben:
> On Thu, Oct 29, 2015 at 09:11:15AM +0100, Kevin Wolf wrote:
> > In qemu proper, you can use a dot syntax for -drive instead:
> > 
> >     qemu-system-x86_64 -drive \
> >     driver=luks,\
> >     secret=x,\
> >     file.driver=file,\
> >     file.filename=test.luks
> > 
> > In qemu-io, you can't use such syntax on the command line, but the open
> > command supports an -o option that accepts the same dot syntax.
> > 
> > Note that qemu-img can't deal with this stuff yet, so you'll have
> > trouble creating an image with such a specification. I guess you need to
> > create it as a local file first and then use non-qemu tools to copy it
> > somewhere where it's exported by rbd, iscsi or gluster.
> 
> I wonder if my patches to qemu-io & qemu-img here do the right thing to
> make this dot syntax work....
> 
>    https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04382.html
>    https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04375.html

I haven't looked at the series in detail yet, but considering that it's
probably harder to prevent it from working than getting it, I assume
that your patches do allow it.

Just passing the options QDict to bdrv_open() is enough, nesting is
represented with the dot syntax in the keys there. In fact, if you use
blockdev-add in QMP, it first converts the options to a flattened QDict
with dot syntax for the keys before it processes it.

Kevin