From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48727)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1ZrpKj-0006id-0Z
	for qemu-devel@nongnu.org; Thu, 29 Oct 2015 11:41:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1ZrpKf-0003k6-Im
	for qemu-devel@nongnu.org; Thu, 29 Oct 2015 11:41:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39256)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1ZrpKf-0003k2-Dh
	for qemu-devel@nongnu.org; Thu, 29 Oct 2015 11:41:41 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (Postfix) with ESMTPS id 68B9B8E37B
	for <qemu-devel@nongnu.org>; Thu, 29 Oct 2015 15:41:40 +0000 (UTC)
Date: Thu, 29 Oct 2015 11:41:38 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20151029114138.560e8582@redhat.com>
In-Reply-To: <1446117309-15322-1-git-send-email-armbru@redhat.com>
References: <1446117309-15322-1-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, 29 Oct 2015 12:15:09 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> Leak introduced in commit 8a4f501..710aec9, v2.4.0.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

I think this can go through your tree?

> ---
>  monitor.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/monitor.c b/monitor.c
> index 301a143..c59e85b 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3862,6 +3862,7 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens)
>  err_out:
>      monitor_protocol_emitter(mon, data, local_err);
>      qobject_decref(data);
> +    error_free(local_err);
>      QDECREF(input);
>      QDECREF(args);
>  }