* [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error
@ 2015-10-29 11:15 Markus Armbruster
2015-10-29 14:31 ` Eric Blake
2015-10-29 15:41 ` Luiz Capitulino
0 siblings, 2 replies; 6+ messages in thread
From: Markus Armbruster @ 2015-10-29 11:15 UTC (permalink / raw)
To: qemu-devel; +Cc: lcapitulino
Leak introduced in commit 8a4f501..710aec9, v2.4.0.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
monitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/monitor.c b/monitor.c
index 301a143..c59e85b 100644
--- a/monitor.c
+++ b/monitor.c
@@ -3862,6 +3862,7 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens)
err_out:
monitor_protocol_emitter(mon, data, local_err);
qobject_decref(data);
+ error_free(local_err);
QDECREF(input);
QDECREF(args);
}
--
2.4.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error
2015-10-29 11:15 [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error Markus Armbruster
@ 2015-10-29 14:31 ` Eric Blake
2015-10-29 15:41 ` Luiz Capitulino
1 sibling, 0 replies; 6+ messages in thread
From: Eric Blake @ 2015-10-29 14:31 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: lcapitulino
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
On 10/29/2015 05:15 AM, Markus Armbruster wrote:
> Leak introduced in commit 8a4f501..710aec9, v2.4.0.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> monitor.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/monitor.c b/monitor.c
> index 301a143..c59e85b 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3862,6 +3862,7 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens)
> err_out:
> monitor_protocol_emitter(mon, data, local_err);
> qobject_decref(data);
> + error_free(local_err);
> QDECREF(input);
> QDECREF(args);
> }
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error
2015-10-29 11:15 [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error Markus Armbruster
2015-10-29 14:31 ` Eric Blake
@ 2015-10-29 15:41 ` Luiz Capitulino
2015-10-29 16:23 ` Markus Armbruster
1 sibling, 1 reply; 6+ messages in thread
From: Luiz Capitulino @ 2015-10-29 15:41 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
On Thu, 29 Oct 2015 12:15:09 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> Leak introduced in commit 8a4f501..710aec9, v2.4.0.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
I think this can go through your tree?
> ---
> monitor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/monitor.c b/monitor.c
> index 301a143..c59e85b 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -3862,6 +3862,7 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens)
> err_out:
> monitor_protocol_emitter(mon, data, local_err);
> qobject_decref(data);
> + error_free(local_err);
> QDECREF(input);
> QDECREF(args);
> }
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error
2015-10-29 15:41 ` Luiz Capitulino
@ 2015-10-29 16:23 ` Markus Armbruster
2015-10-29 19:06 ` Luiz Capitulino
0 siblings, 1 reply; 6+ messages in thread
From: Markus Armbruster @ 2015-10-29 16:23 UTC (permalink / raw)
To: Luiz Capitulino; +Cc: qemu-devel
Luiz Capitulino <lcapitulino@redhat.com> writes:
> On Thu, 29 Oct 2015 12:15:09 +0100
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Leak introduced in commit 8a4f501..710aec9, v2.4.0.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Thanks!
> I think this can go through your tree?
Yes, along with the json-streamer work.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error
2015-10-29 16:23 ` Markus Armbruster
@ 2015-10-29 19:06 ` Luiz Capitulino
2015-10-30 7:35 ` Markus Armbruster
0 siblings, 1 reply; 6+ messages in thread
From: Luiz Capitulino @ 2015-10-29 19:06 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel
On Thu, 29 Oct 2015 17:23:43 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> Luiz Capitulino <lcapitulino@redhat.com> writes:
>
> > On Thu, 29 Oct 2015 12:15:09 +0100
> > Markus Armbruster <armbru@redhat.com> wrote:
> >
> >> Leak introduced in commit 8a4f501..710aec9, v2.4.0.
> >>
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >
> > Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
>
> Thanks!
>
> > I think this can go through your tree?
>
> Yes, along with the json-streamer work.
Do you need my review for that one? It's been ages that I don't
look at that code, I'm not sure it's going to be that worthwhile.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error
2015-10-29 19:06 ` Luiz Capitulino
@ 2015-10-30 7:35 ` Markus Armbruster
0 siblings, 0 replies; 6+ messages in thread
From: Markus Armbruster @ 2015-10-30 7:35 UTC (permalink / raw)
To: Luiz Capitulino; +Cc: qemu-devel
Luiz Capitulino <lcapitulino@redhat.com> writes:
> On Thu, 29 Oct 2015 17:23:43 +0100
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> Luiz Capitulino <lcapitulino@redhat.com> writes:
>>
>> > On Thu, 29 Oct 2015 12:15:09 +0100
>> > Markus Armbruster <armbru@redhat.com> wrote:
>> >
>> >> Leak introduced in commit 8a4f501..710aec9, v2.4.0.
>> >>
>> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> >
>> > Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
>>
>> Thanks!
>>
>> > I think this can go through your tree?
>>
>> Yes, along with the json-streamer work.
>
> Do you need my review for that one? It's been ages that I don't
> look at that code, I'm not sure it's going to be that worthwhile.
Review is always welcome, but "need" is too strong. qobject/json* isn't
your code anyway, and I got Eric's review already.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-30 7:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-29 11:15 [Qemu-devel] [PATCH] monitor: Plug memory leak on QMP error Markus Armbruster
2015-10-29 14:31 ` Eric Blake
2015-10-29 15:41 ` Luiz Capitulino
2015-10-29 16:23 ` Markus Armbruster
2015-10-29 19:06 ` Luiz Capitulino
2015-10-30 7:35 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).