From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrtW8-0004iO-MW for qemu-devel@nongnu.org; Thu, 29 Oct 2015 16:09:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZrtW5-0008S8-G7 for qemu-devel@nongnu.org; Thu, 29 Oct 2015 16:09:48 -0400 Received: from e19.ny.us.ibm.com ([129.33.205.209]:48410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZrtW5-0008Qv-BR for qemu-devel@nongnu.org; Thu, 29 Oct 2015 16:09:45 -0400 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 29 Oct 2015 16:09:43 -0400 Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 7C9FB38C803B for ; Thu, 29 Oct 2015 16:09:40 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t9TK9eAI65929314 for ; Thu, 29 Oct 2015 20:09:40 GMT Received: from d01av03.pok.ibm.com (localhost [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t9TK9e15000780 for ; Thu, 29 Oct 2015 16:09:40 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1446045237-19532-1-git-send-email-den@openvz.org> References: <1446045237-19532-1-git-send-email-den@openvz.org> Message-ID: <20151029200930.4255.86421@loki> Date: Thu, 29 Oct 2015 15:09:30 -0500 Subject: Re: [Qemu-devel] [PATCH v4 for 2.5 0/3] qga: non-blocking fd cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Yuri Pudgorodskiy , qemu-devel@nongnu.org, Olga Krishtal Quoting Denis V. Lunev (2015-10-28 10:13:54) > This patchset is reincarnation of one patch discussed in the scope of > QEMU 2.4 and rejected for that time. Actually we should use > non-blocking descriptors in QGA on Windows in guest-file-open exactly > like was done for Posix. > = > Changes from v3: > - handle_set_nonblocking now is local function in qga/commands-win32.c > It works only in one way - set handle nonblocking. > = > Changes from v2: > - added fix for wrong argument to CloseHandle > - switched setting non-block for pipes to use separate function > = > Changes from v1: > - call to qemu_fd_register is moved to a proper place > - moved declaration of opt to a proper place > = > Signed-off-by: Denis V. Lunev > Signed-off-by: Olga Krishtal > CC: Yuri Pudgorodskiy > CC: Michael Roth > = > Denis V. Lunev (1): > qga: drop hand-made guest_file_toggle_flags helper > = > Olga Krishtal (2): > qga: fixed CloseHandle in qmp_guest_file_open > qga: set file descriptor in qmp_guest_file_open non-blocking on Win32 Thanks, applied to qga tree: https://github.com/mdroth/qemu/commits/qga > = > qga/commands-posix.c | 27 ++------------------------- > qga/commands-win32.c | 29 ++++++++++++++++++++++++++++- > 2 files changed, 30 insertions(+), 26 deletions(-) > = > -- = > 2.1.4 >=20