qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sam Bobroff <sam.bobroff@au1.ibm.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] monitor: correct socket listen port
Date: Fri, 30 Oct 2015 09:07:31 +1100	[thread overview]
Message-ID: <20151029220731.GA1907@tungsten.ozlabs.ibm.com> (raw)
In-Reply-To: <871tce8a2h.fsf@blackfin.pond.sub.org>

On Thu, Oct 29, 2015 at 07:26:14AM +0100, Markus Armbruster wrote:
> Sam Bobroff <sam.bobroff@au1.ibm.com> writes:
> 
> > Currently when constructing an inet socket monitor (e.g. via "-monitor
> > telent:localhost:12345,server,nowait") the port is ignored and a
> > random one is used instead. It appears this behaviour was accidentally
> > introduced by commit dafd325d "qemu-char: Convert socket backend to
> > QAPI".
> >
> > The cause is that the has_port field is not set in the address, so
> > later it is not copied by qapi_copy_SocketAddress(). This patch simply
> > adds the missing "has_port = true".
> >
> > Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
> > ---
> >
> >  qemu-char.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/qemu-char.c b/qemu-char.c
> > index c4eb4ee..4fb9279 100644
> > --- a/qemu-char.c
> > +++ b/qemu-char.c
> > @@ -3605,6 +3605,7 @@ static void qemu_chr_parse_socket(QemuOpts *opts, ChardevBackend *backend,
> >          addr->kind = SOCKET_ADDRESS_KIND_INET;
> >          addr->inet = g_new0(InetSocketAddress, 1);
> >          addr->inet->host = g_strdup(host);
> > +        addr->inet->has_port = true;
> >          addr->inet->port = g_strdup(port);
> >          addr->inet->has_to = qemu_opt_get(opts, "to");
> >          addr->inet->to = qemu_opt_get_number(opts, "to", 0);
> 
> Please see "[PATCH] qapi-schema: mark InetSocketAddress as mandatory
> again"
> Message-Id: <1445509543-30679-1-git-send-email-berrange@redhat.com>
> http://lists.nongnu.org/archive/html/qemu-devel/2015-10/msg05222.html

Ah thanks, that's obviously the correct fix too.
(Guess I'm one of the ones who got bitten ;-)

Cheers,
Sam.

      reply	other threads:[~2015-10-29 22:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 22:15 [Qemu-devel] [PATCH 1/1] monitor: correct socket listen port Sam Bobroff
2015-10-29  6:26 ` Markus Armbruster
2015-10-29 22:07   ` Sam Bobroff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151029220731.GA1907@tungsten.ozlabs.ibm.com \
    --to=sam.bobroff@au1.ibm.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).