From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zs95Q-0002D3-Hx for qemu-devel@nongnu.org; Fri, 30 Oct 2015 08:47:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zs95M-0005Jx-DJ for qemu-devel@nongnu.org; Fri, 30 Oct 2015 08:47:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zs95M-0005Je-8M for qemu-devel@nongnu.org; Fri, 30 Oct 2015 08:47:12 -0400 Date: Fri, 30 Oct 2015 12:47:05 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20151030124704.GK2417@work-vm> References: <1443515898-3594-1-git-send-email-dgilbert@redhat.com> <1443515898-3594-5-git-send-email-dgilbert@redhat.com> <20151005064411.GE21612@grmbl.mre> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151005064411.GE21612@grmbl.mre> Subject: Re: [Qemu-devel] [PATCH v8 04/54] Move configuration section writing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: aarcange@redhat.com, quintela@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, luis@cs.umu.se, bharata@linux.vnet.ibm.com, pbonzini@redhat.com * Amit Shah (amit.shah@redhat.com) wrote: > On (Tue) 29 Sep 2015 [09:37:28], Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > The vmstate_configuration is currently written > > in 'qemu_savevm_state_begin', move it to > > 'qemu_savevm_state_header' since it's got a hard > > requirement that it must be the 1st thing after > > the header. > > (In postcopy some 'command' sections get sent > > early before the saving of the main sections > > and hence before qemu_savevm_state_begin). > > > > Signed-off-by: Dr. David Alan Gilbert > > Reviewed-by: Amit Shah > > The function name 'savevm_state_header()' isn't accurate anymore. Not > serious for this series. Well, it does still write the header; but if you have a simple better name, I'd be happy to change it. Dave > > Amit -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK