From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zs9nz-0002Cc-Bu for qemu-devel@nongnu.org; Fri, 30 Oct 2015 09:33:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zs9nw-0001Jg-5b for qemu-devel@nongnu.org; Fri, 30 Oct 2015 09:33:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36215) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zs9nw-0001Ja-1F for qemu-devel@nongnu.org; Fri, 30 Oct 2015 09:33:16 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 9D680A3D31 for ; Fri, 30 Oct 2015 13:33:15 +0000 (UTC) Date: Fri, 30 Oct 2015 08:33:08 -0500 From: Andrew Jones Message-ID: <20151030133308.GD8197@hawk.localdomain> References: <1446057425-16891-1-git-send-email-ehabkost@redhat.com> <1446057425-16891-10-git-send-email-ehabkost@redhat.com> <8737wtwqh2.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8737wtwqh2.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH v2 09/16] vl.c: Reword -no-kvm-pit-reinjection deprecation warning List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Paolo Bonzini , Eduardo Habkost , qemu-devel@nongnu.org On Thu, Oct 29, 2015 at 06:10:17PM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > Signed-off-by: Eduardo Habkost > > --- > > vl.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/vl.c b/vl.c > > index af8d09c..67147e0 100644 > > --- a/vl.c > > +++ b/vl.c > > @@ -3667,8 +3667,8 @@ int main(int argc, char **argv, char **envp) > > { /* end of list */ } > > }; > > > > - error_report("warning: option deprecated, use " > > - "lost_tick_policy property of kvm-pit instead"); > > + error_report("warning: -no-kvm-pit-reinjection deprecated by " > > + "-global kvm-pit.lost_tick_policy=discard"); > > qdev_prop_register_global_list(kvm_pit_lost_tick_policy); > > break; > > } > > Repeating the option in the error message rarely improves the message, > because error_report() already shows it. It's actually misleading when > the option comes from a configuration file read with -readconfig. > > Fortunately, -readconfig doesn't support the option, so that's not an > issue here. > > For the command line, the message changes from > > qemu-system-x86_64: -no-kvm-pit-reinjection: warning: option deprecated, use lost_tick_policy property of kvm-pit instead > > to > > qemu-system-x86_64: -no-kvm-pit-reinjection: warning: -no-kvm-pit-reinjection deprecated by -global kvm-pit.lost_tick_policy=discard > > Perhaps: > > qemu-system-x86_64: -no-kvm-pit-reinjection: warning: deprecated, replaced by -global kvm-pit.lost_tick_policy=discard > > Similar argument for PATCH 08. > Ah, I hadn't looked closely enough at error_report to know that the option would be output already with my "ignoring" phrase suggestion. I definitely agree that repeating it should be avoided. "warning: deprecated, ignoring" Thanks, drew