From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/4] io: add locking constraints check into bdrv_drain to ensure locking
Date: Fri, 30 Oct 2015 15:43:24 +0000 [thread overview]
Message-ID: <20151030154324.GC16864@stefanha-x1.localdomain> (raw)
In-Reply-To: <1446044465-19312-4-git-send-email-den@openvz.org>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
On Wed, Oct 28, 2015 at 06:01:04PM +0300, Denis V. Lunev wrote:
> as described in the comment of the function
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/io.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/block/io.c b/block/io.c
> index 5ac6256..2e98d45 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -247,12 +247,15 @@ bool bdrv_requests_pending(BlockDriverState *bs)
> void bdrv_drain(BlockDriverState *bs)
> {
> bool busy = true;
> + AioContext *aio_context = bdrv_get_aio_context(bs);
> +
> + assert(aio_context_is_locked(aio_context));
Cool, thanks! This is a useful assertion to have.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-30 15:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 15:01 [Qemu-devel] [PATCH v3 0/4] dataplane snapshot fixes Denis V. Lunev
2015-10-28 15:01 ` [Qemu-devel] [PATCH 1/4] fifolock: create rfifolock_is_locked helper Denis V. Lunev
2015-10-30 15:41 ` Stefan Hajnoczi
2015-10-30 20:30 ` Denis V. Lunev
2015-11-02 13:10 ` Stefan Hajnoczi
2015-11-01 13:55 ` Denis V. Lunev
2015-11-02 13:12 ` Stefan Hajnoczi
2015-11-02 13:39 ` Denis V. Lunev
2015-11-02 13:55 ` Paolo Bonzini
2015-11-02 14:02 ` Denis V. Lunev
2015-10-28 15:01 ` [Qemu-devel] [PATCH 2/4] aio_context: create aio_context_is_locked helper Denis V. Lunev
2015-10-30 15:42 ` Stefan Hajnoczi
2015-10-28 15:01 ` [Qemu-devel] [PATCH 3/4] io: add locking constraints check into bdrv_drain to ensure locking Denis V. Lunev
2015-10-30 15:43 ` Stefan Hajnoczi [this message]
2015-10-28 15:01 ` [Qemu-devel] [PATCH 4/4] migration: add missed aio_context_acquire into HMP snapshot code Denis V. Lunev
2015-10-28 15:33 ` Juan Quintela
2015-10-28 15:57 ` Denis V. Lunev
2015-10-30 15:52 ` Stefan Hajnoczi
2015-11-03 14:48 ` Juan Quintela
2015-11-03 15:30 ` Stefan Hajnoczi
2015-11-03 15:36 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151030154324.GC16864@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=den@openvz.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).