From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtPPD-0007ZQ-3X for qemu-devel@nongnu.org; Mon, 02 Nov 2015 19:24:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtPP9-00087h-Rm for qemu-devel@nongnu.org; Mon, 02 Nov 2015 19:24:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtPP9-00087Z-N1 for qemu-devel@nongnu.org; Mon, 02 Nov 2015 19:24:51 -0500 Date: Tue, 3 Nov 2015 08:24:47 +0800 From: Fam Zheng Message-ID: <20151103002447.GA6246@ad.usersys.redhat.com> References: <1446473183-24250-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446473183-24250-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH] configure: add missing --disable-modules option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Peter Maydell , qemu-devel@nongnu.org, guydavid@outlook.com On Mon, 11/02 14:06, Stefan Hajnoczi wrote: > According to ./configure all options should have both --enable-foo and > --disable-foo: > > # Always add --enable-foo and --disable-foo command line args. > # Distributions want to ensure that several features are compiled in, and it > # is impossible without a --enable-foo that exits if a feature is not found. Actually the document is wrong about module support, the default is off: > Optional features, enabled with --enable-FEATURE and > disabled with --disable-FEATURE, default is enabled if available: Maybe we should move it out of this section instead? What about vnc-tls? It's described in the same place, but there is no option for it. Fam