Re: [Qemu-devel] [PATCH] qemu-img: add check for zero-length job len

[Jeff Cody <jcody@redhat.com>]

On Mon, Nov 02, 2015 at 06:28:20PM -0500, John Snow wrote:
> The mirror job doesn't update its total length until
> it has already started running, so we should translate
> a zero-length job-len as meaning 0%.
> 
> Otherwise, we may get divide-by-zero faults.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  qemu-img.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/qemu-img.c b/qemu-img.c
> index 3025776..38b4888 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -656,7 +656,8 @@ static void run_block_job(BlockJob *job, Error **errp)
>  
>      do {
>          aio_poll(aio_context, true);
> -        qemu_progress_print((float)job->offset / job->len * 100.f, 0);
> +        qemu_progress_print(job->len ?
> +                            ((float)job->offset / job->len * 100.f) : 0.00, 0);
>      } while (!job->ready);
>  
>      block_job_complete_sync(job, errp);
> -- 
> 2.4.3
>

Reviewed-by: Jeff Cody <jcody@redhat.com>