From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtPPH-0007cZ-Mp for qemu-devel@nongnu.org; Mon, 02 Nov 2015 19:25:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtPPG-00088F-Uh for qemu-devel@nongnu.org; Mon, 02 Nov 2015 19:24:59 -0500 Date: Mon, 2 Nov 2015 16:24:53 -0800 From: Jeff Cody Message-ID: <20151103002453.GA15533@localhost.localdomain> References: <1446506900-27733-1-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446506900-27733-1-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qemu-img: add check for zero-length job len List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org On Mon, Nov 02, 2015 at 06:28:20PM -0500, John Snow wrote: > The mirror job doesn't update its total length until > it has already started running, so we should translate > a zero-length job-len as meaning 0%. > > Otherwise, we may get divide-by-zero faults. > > Signed-off-by: John Snow > --- > qemu-img.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 3025776..38b4888 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -656,7 +656,8 @@ static void run_block_job(BlockJob *job, Error **errp) > > do { > aio_poll(aio_context, true); > - qemu_progress_print((float)job->offset / job->len * 100.f, 0); > + qemu_progress_print(job->len ? > + ((float)job->offset / job->len * 100.f) : 0.00, 0); > } while (!job->ready); > > block_job_complete_sync(job, errp); > -- > 2.4.3 > Reviewed-by: Jeff Cody