From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtcYC-00071d-8L for qemu-devel@nongnu.org; Tue, 03 Nov 2015 09:27:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtcY9-0003Hl-0l for qemu-devel@nongnu.org; Tue, 03 Nov 2015 09:27:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtcY8-0003Hg-SA for qemu-devel@nongnu.org; Tue, 03 Nov 2015 09:27:00 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 79327C10044A for ; Tue, 3 Nov 2015 14:27:00 +0000 (UTC) Date: Tue, 3 Nov 2015 09:26:59 -0500 From: Luiz Capitulino Message-ID: <20151103092659.126ab97c@redhat.com> In-Reply-To: <5638BC77.5010102@redhat.com> References: <5633C8EC.8030309@redhat.com> <874mh44wvs.fsf@blackfin.pond.sub.org> <56378572.5020203@redhat.com> <87egg8nro5.fsf@blackfin.pond.sub.org> <5637C2B3.6090609@redhat.com> <87egg7lffd.fsf@blackfin.pond.sub.org> <20151103081917.1d348ad1@redhat.com> <5638B8DE.6020709@redhat.com> <20151103084643.26d71554@redhat.com> <5638BC77.5010102@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] RFC: libyajl for JSON List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Markus Armbruster , "Dr. David Alan Gilbert" , "qemu-devel@nongnu.org" On Tue, 3 Nov 2015 14:53:59 +0100 Paolo Bonzini wrote: > On 03/11/2015 14:46, Luiz Capitulino wrote: > >> > Can you explain why that would make sense? :) (Especially since there > >> > is another extension---JSON5---that does exactly what we're doing, so it > >> > probably wasn't that stupid an idea). > > Let's be pragmatic. *If* this is the only issue stopping us from > > dropping our own parser in favor of something more widely used and > > *if* libvirt doesn't make use of the feature, it's something we > > should strongly consider. > > I'm not sure what's so bad about our parser that makes it worthwhile to: It's not that it's bad. It's about the advantages of dropping hundreds of lines of NIH code and switching to something more widely used. Also, any maintenance time we spend on libyajl will also be automatically enjoyed by libvirt which is excellent. On the other hand, I don't want to push too hard for it because I do recognize that switching has a cost and I won't be able to help with that myself. > 1) uglify all tests and make them inconsistent with the QAPI schemas, > which also uses single-quoted strings This doesn't seem hard to fix, we could pre-process the test files, say in Python, to add the needed escaping. > 2) waste time finding a replacement for % interpolation (the best > replacement here would be to rewrite the tests in Python IMHO, but > that's not a small ask) Is this only used by tests? Can you give an example of this feature? > > Just let's remove the weird (to not say worse) usage of QDict/QList to > store tokens... > > Paolo >